Skip to content

don't hardcode version in client bundle - #7694

Merged
dummdidumm merged 1 commit into
masterfrom
gh-7144
Nov 17, 2022
Merged

don't hardcode version in client bundle#7694
dummdidumm merged 1 commit into
masterfrom
gh-7144

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

fixes #7144. #7689 makes this nice and easy

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot

changeset-bot Bot commented Nov 16, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0177476

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
dummdidumm merged commit d3a5db3 into master Nov 17, 2022
@dummdidumm
dummdidumm deleted the gh-7144 branch November 17, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Converting an undefined kit.version.name in to a Date.now(), a hardcoded timestamp gets added and generates unique static files for each build

3 participants