Skip to content

fix: allow handle functions composed with sequence to run without a request store - #16596

Open
Nic-Polumeyv wants to merge 8 commits into
sveltejs:version-3from
Nic-Polumeyv:fix-sequence-request-store
Open

fix: allow handle functions composed with sequence to run without a request store#16596
Nic-Polumeyv wants to merge 8 commits into
sveltejs:version-3from
Nic-Polumeyv:fix-sequence-request-store

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

fixes #14249

Since #13899 the handle returned by sequence calls get_request_store() before running any handler, so invoking it directly (the unit testing case in the issue) throws. This swaps in try_get_request_store() and degrades the way elliott described in the issue thread.

The spec no longer needs to mock @sveltejs/kit/internal/server to get past the throw; the tests now run against the real modules.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 31, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 5f78c1a:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/5f78c1aeb772c943dbab5ac3248f127a214d7169

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16596

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5f78c1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not get the request store During Server Test

1 participant