fix: allow routes to contain [ and ] via the [x+5b] and [x+5d] escapes - #16569
Merged
Rich-Harris merged 1 commit intoJul 30, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/6031e0c2ab590c8329bbf056f4d2f0382613bc00Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 6031e0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
#16570 fixes the other half of this: |
Rich-Harris
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[and]escapes prescribed indocumentation/docs/30-advanced/10-advanced-routing.mdhave never worked: a route directory named[x+5b]fails the build withInvalid regular expression: /^/\\[/?$/: Unterminated character class, and[x+5d]compiles to a pattern that cannot match/]. Introduced with the escape syntax itself in #7644.escape()escapes[and]first to protect the%2[Ff]and%3[Ff]classes the URL substitutions emit, then its final pass re-escapes those backslashes because\\is in its character class. Regex escaping now runs before the substitutions rather than around them.parse_route_idoutput is byte-identical toversion-3for every printable ASCII character and 23 mixed route ids; only[x+5b]and[x+5d]change.