fix: prerender and crawl pages whose content-type header carries a charset parameter - #16567
Merged
Rich-Harris merged 2 commits intoJul 30, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d961820b0848bacf2d5c1d595c52d35ef24ac46cOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d961820 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prerenderer compares
content-typewith===, sotext/html; charset=utf-8is not treated as HTML: the page is written without a.htmlextension and its links are never crawled.is_content_typealready normalizes the header for this reason, from #7195 (strip parameters) and GHSA-gv7g-x59x-wf8f (case-insensitive compare); the two prerender checks predate both.Reproduces #13612, closed as unreproducible, using the charset workaround from #3184. The root
+server.jserror added in #15994 is gated on the same value, so it can fire for an app that has none.