Skip to content

chore: fix up vitest configs and ci - #16555

Merged
teemingc merged 12 commits into
version-3from
faster-ci
Jul 29, 2026
Merged

chore: fix up vitest configs and ci#16555
teemingc merged 12 commits into
version-3from
faster-ci

Conversation

@teemingc

@teemingc teemingc commented Jul 28, 2026

Copy link
Copy Markdown
Member

The test-kit CI jobs take more than 17 minutes each because it's several consecutive groups of tests. If one test fails, everything needs to be retried and that's another 17 minutes. Separating them into unit, dev, and build, might make it a little faster since they run in parallel and it also makes test retries less painful. This may take up more CI minutes but definitely less wall clock time.

This PR also tightens the Vitest workspace config so that it works with both the VS Code Vitest extension and the built-in one for Zed.

EDIT: it takes 10 minutes to complete everything now

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 28, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 1c86eae:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1c86eaee36abbf151ddecfad2d3e7cf6c736dad1

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16555

@svelte-docs-bot

Copy link
Copy Markdown

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vitest expects vitest.*.config.js filenames otherwise the extension throws

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks my guy

@elliott-with-the-longest-name-on-github

Copy link
Copy Markdown
Contributor

Noticed this is draft but it looks done?

@teemingc

Copy link
Copy Markdown
Member Author

Yeah there are a few vitest run scripts that still need to be fixed. It’s running all the unit tests rather just the ones in the directory

@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1c86eae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teemingc
teemingc marked this pull request as ready for review July 29, 2026 07:31
Comment thread packages/kit/package.json
Comment thread packages/kit/package.json
@teemingc
teemingc marked this pull request as draft July 29, 2026 08:40
Comment thread .github/workflows/ci.yml Outdated
Comment thread packages/kit/test/apps/basics/vite.config.js Outdated
@teemingc
teemingc marked this pull request as ready for review July 29, 2026 11:34
@teemingc
teemingc merged commit 45d25d2 into version-3 Jul 29, 2026
24 checks passed
@teemingc
teemingc deleted the faster-ci branch July 29, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants