chore: require form and error in the Props constructor - #16554
Merged
Rich-Harris merged 2 commits intoJul 29, 2026
Conversation
also drop the unused pending_invalidate export
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/e19bcce127b7eaa124c6e08ce0648703deebef29Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
Nic-Polumeyv
marked this pull request as ready for review
July 28, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
props.formandprops.errorwere each missed on the SSR side during review of #16547 and fixed in follow-up commits. Passing them through the constructor makes the next missed one a type error instead of a silentundefinedin the rendered page.pending_invalidatelost itsexportsince nothing imports it.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits