Skip to content

chore: require form and error in the Props constructor - #16554

Merged
Rich-Harris merged 2 commits into
sveltejs:version-3from
Nic-Polumeyv:props-total-constructor
Jul 29, 2026
Merged

chore: require form and error in the Props constructor#16554
Rich-Harris merged 2 commits into
sveltejs:version-3from
Nic-Polumeyv:props-total-constructor

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

props.form and props.error were each missed on the SSR side during review of #16547 and fixed in follow-up commits. Passing them through the constructor makes the next missed one a type error instead of a silent undefined in the rendered page.

pending_invalidate lost its export since nothing imports it.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

also drop the unused pending_invalidate export
@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 28, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from e19bcce:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/e19bcce127b7eaa124c6e08ce0648703deebef29

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16554

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e19bcce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nic-Polumeyv
Nic-Polumeyv marked this pull request as ready for review July 28, 2026 22:49

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Rich-Harris
Rich-Harris merged commit 58ab41a into sveltejs:version-3 Jul 29, 2026
17 of 18 checks passed
@Nic-Polumeyv
Nic-Polumeyv deleted the props-total-constructor branch July 30, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants