fix: prevent unhandled promise rejection - #16219
Merged
Merged
Conversation
If the promise fails, nobody catches it, which can take down the process. I added `.catch(...)` in two more places out of abundance of caution. They can right now not result in an unhandled promise rejection (because other code paths make sure they never throw) but if they start to in the future it's better to safe-guard against it now already.
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/8c1cea1b442f251188a9be14e43264d1f020553dOpen in |
🦋 Changeset detectedLatest commit: 8c1cea1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Jul 2, 2026
Merged
dummdidumm
pushed a commit
that referenced
this pull request
Jul 2, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.69.1 ### Patch Changes - fix: prevent prototype pollution when deleting file inputs ([#16218](#16218)) - fix: prevent unhandled promise rejection ([#16219](#16219)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the promise fails, nobody catches it, which can take down the process.
I added
.catch(...)in two more places out of abundance of caution. They can right now not result in an unhandled promise rejection (because other code paths make sure they never throw) but if they start to in the future it's better to safe-guard against it now already.