Skip to content

chore: bump cookie to v2 - #16184

Merged
teemingc merged 4 commits into
version-3from
cookie-v2
Jun 27, 2026
Merged

chore: bump cookie to v2#16184
teemingc merged 4 commits into
version-3from
cookie-v2

Conversation

@teemingc

@teemingc teemingc commented Jun 26, 2026

Copy link
Copy Markdown
Member

closes #16172

Bumps cookie from v1 to v2 which is ESM-only and changes its method names and signature for serialising a set-cookie value https://github.com/jshttp/cookie/releases/tag/v2.0.0 but our lockfile still has cookie v1 because of some Netlify deps but we will get rid of that when we move to platform tests

We should make a decision if we want to change our methods to match the new cookie API or leave it as is

EDIT: we decided to stick to our current API in the June monthly meeting


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4b701bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teemingc teemingc linked an issue Jun 26, 2026 that may be closed by this pull request
Comment thread packages/kit/src/runtime/server/cookie.js Outdated
@teemingc teemingc added this to the 3.0 milestone Jun 26, 2026
@teemingc teemingc added needs-decision Not sure if we want to do this yet, also design work needed and removed needs-decision Not sure if we want to do this yet, also design work needed labels Jun 26, 2026
@teemingc teemingc removed this from the 3.0 milestone Jun 26, 2026
Comment thread pnpm-workspace.yaml Outdated
- prettier-plugin-svelte
- svelte-check
- esm-env
- cookie@2.0.0 # TODO: remove this once it's been released long enough

@teemingc teemingc Jun 26, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just wait a few hours or a day so we can get rid of this. It'll allow the preview docs to deploy too since it's currently erroring from this version being too new

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for whenever we pass minimumReleaseAge

@svelte-docs-bot

Copy link
Copy Markdown

@teemingc
teemingc merged commit a3dd5fa into version-3 Jun 27, 2026
18 checks passed
@teemingc
teemingc deleted the cookie-v2 branch June 27, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to cookie v2

2 participants