fix(RemoteCommand): restore Awaited<Output> to unwrap Promise handlers - #15814
Closed
Zelys-DFKH wants to merge 1 commit into
Closed
fix(RemoteCommand): restore Awaited<Output> to unwrap Promise handlers#15814Zelys-DFKH wants to merge 1 commit into
Zelys-DFKH wants to merge 1 commit into
Conversation
Fixes sveltejs#15763 PR sveltejs#15533 removed Awaited<> from RemoteCommand type signatures, causing Promise-returning handlers to produce Promise<Promise<T>> instead of Promise<T>. When a command handler returns Promise<T>, the Output generic is inferred as Promise<T>. Without Awaited<>, this results in a nested Promise type. Restoring Awaited<Output> in both the call signature and updates() method ensures proper Promise unwrapping, matching the behavior of form() and query(), which use MaybePromise<Output>.
|
Contributor
Author
|
This fix was already merged in PR #15771. Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15763
PR #15533 removed
Awaited<>from RemoteCommand type signatures, causing Promise-returning handlers to producePromise<Promise<T>>instead ofPromise<T>.When a command handler returns
Promise<T>, the Output generic is inferred asPromise<T>. WithoutAwaited<>, this results in a nested Promise type.Restoring
Awaited<Output>in both the call signature andupdates()method ensures proper Promise unwrapping, matching the behavior ofform()andquery(), which useMaybePromise<Output>.Changes
Awaited<Output>in RemoteCommand type definition (packages/kit/types/index.d.ts)