Skip to content

fix: remote forms with default values defined by field.as('text', defaultValue) now correctly reset to the provided default values once submitted - #15753

Merged
elliott-with-the-longest-name-on-github merged 6 commits into
sveltejs:mainfrom
ottomated:form-reset-default-values
Apr 29, 2026
Merged

Conversation

@ottomated

@ottomated ottomated commented Apr 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Without JS enabled, a form like this:

<form {...my_form}>
  <input {...my_form.fields.foo.as('text', 'default')} />
  <button>Submit</button>
</form>

will reset the text field to "default" when submitted. With progressive enhancement, when form.reset() is called on submission by SvelteKit, the text field is incorrectly reset to "".

This PR fixes that by adding defaultValue and defaultChecked to the object returned from .as(). It seems like the behavior for <select> elements was already correct?

Depends on #15752 for correct checkbox behavior.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Apr 25, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c357840

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

svelte-docs-bot Bot commented Apr 25, 2026

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-15753-svelte.vercel.app/

@elliott-with-the-longest-name-on-github

elliott-with-the-longest-name-on-github commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

I'm sorry, I think I caused you conflicts :(

elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github reviewed Apr 28, 2026
View reviewed changes

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, but I think just needs to be rebased on main now that its upstream has merged

@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github merged commit 1c8e573 into sveltejs:main Apr 29, 2026
26 checks passed
This was referenced Apr 29, 2026
Merged
Merged
@ottomated
ottomated deleted the form-reset-default-values branch April 29, 2026 20:51
Rich-Harris pushed a commit that referenced this pull request May 1, 2026
@github-actions
Version Packages (#15769)
522ac32 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/kit@2.59.0

### Minor Changes

- feat: support `query.batch` in `requested(...)`
([#15751](#15751))


- breaking: on the server, make the promise returned from `refresh`
represent adding the refresh to the map, not the time it takes to run
the remote function
([#15705](#15705))


- feat: experimental `query.live` function
([#15705](#15705))

### Patch Changes

- fix: unwrap `Promise` in `RemoteCommand` output type
([#15771](#15771))


- fix: empty call to `.updates()` on a command/form invocation means
"don't update anything"
([#15705](#15705))


- fix: `form.fields.foo.as('checkbox', default_value)` now works
([#15752](#15752))


- fix: remote forms with default values defined by `field.as('text',
defaultValue)` now correctly reset to the provided default values once
submitted ([#15753](#15753))


- fix: make sure queries always get started correctly
([#15705](#15705))


- fix: allow plain functions as overrides in `updates`
([#15705](#15705))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ottomated @elliott-with-the-longest-name-on-github