feat: type resolve with the correct trailing slash option - #15027
Merged
Conversation
🦋 Changeset detectedLatest commit: 0c10c56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
changed the title
Member
|
I've left two TODOs in |
Contributor
Author
|
I should get back at it! Thx 👍 |
Contributor
Author
|
I pulled main & looked at the TODOs, let me know what do you think @teemingc Note: the Pathname update is now handled at the sync.js level after write_types() returns |
teemingc
marked this pull request as ready for review
February 12, 2026 18:25
Merged
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
…5027) If we have `routes/path-a/+page.svelte` The function `resolve()` propose us two options today ```ts resolve('/path-a') resolve('/path-a/') ``` As trailing slash default is `never`, I would expect that `resolve('/path-a/')` is not available. If you set `always`, I would expect only `resolve('/path-a/')` to be available. This PR is addressing this. But... not that happy that: - [x] I have to `read` in `packages/kit/src/core/sync/create_manifest_data/index.js` - [x] didn't manage to use https://github.com/jycouet/kit/blob/7acee7aef9ac80614f9a78635cdf4a2a23785961/packages/kit/src/exports/vite/static_analysis/index.js#L213 as it's async I added a few unit tests to help playing around. Any help on the stuff I'm not happy about ? --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com>
This was referenced Jul 30, 2026
elliott-with-the-longest-name-on-github
added a commit
that referenced
this pull request
Jul 30, 2026
…uteId` (#16580) Closes #14847. #15027 fixed the `Path` half of that issue; the `RouteId` union still lists every directory, so `resolve('/a')` type-checks when `/a` only holds child routes. `LayoutParams` now keys off the generated layout map instead of `RouteId`, and a layout sitting in a directory that isn't a route stops claiming its own id in `LayoutRouteId`. `resolve('/')` stops type-checking in an app whose root page lives in a group, since `/(app)` is the route that serves `/`. Write `resolve('')` instead. #16588 covers the `$app/manifest` side. Also points #16588's `routes` filter at `is_app_route` so the two stay in sync, and rewords its changeset to cover the #5793 fix. --------- Co-authored-by: Elliott Johnson <hello@ell.iott.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have
routes/path-a/+page.svelteThe function
resolve()propose us two options todayAs trailing slash default is
never, I would expect thatresolve('/path-a/')is not available.If you set
always, I would expect onlyresolve('/path-a/')to be available.This PR is addressing this.
But... not that happy that:
readinpackages/kit/src/core/sync/create_manifest_data/index.jsI added a few unit tests to help playing around.
Any help on the stuff I'm not happy about ?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits