feat: add option to recursively consider server dirs in $lib - #12733
feat: add option to recursively consider server dirs in $lib#12733rChaoz wants to merge 3 commits into
server dirs in $lib#12733Conversation
🦋 Changeset detectedLatest commit: 9746640 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rChaoz
changed the title
server dirs in $libserver dirs in $lib
|
Instead of adding an option, can we instead make this the default? Would that be considered a breaking change? |
Yes because if for some reason I'm importing a module on the client from |
teemingc
added
needs-decision
|
Related #12480 |
|
Should I bring this up-to-date? Or maybe can this be considered to become the default in v3? |
|
I think it would make sense for this to be the default in v3 — it's probably not worth adding a new option in the meantime, and since this PR has a lot of merge conflicts I'll go ahead and close it. I've given #12732 a 3.0 milestone to ensure it doesn't get left out. Thanks! |
|
@rChaoz if you're still interested in adding this and would like to send a new PR for this, we've started a |
|
Sounds good, I can get around to it most likely next week. |
|
cool! per rich's comment above it can probably be a bit simpler in the |
|
Sorry for the delay, the PR is ready here: #15685 |
closes #12732 Instead of only considering `$lib/server/**` as server-only modules, consider `$lib/**/server/**` instead, see issue above for reasoning. As per the conversation in #12733, adding this as defaults for v3 (breaking change). --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com> Co-authored-by: Elliott Johnson <hello@ell.iott.dev> Co-authored-by: Rich Harris <rich.harris@vercel.com>
6 participants
Closes #12732
This PR adds a new config option
kit.files.nestedServerDirsthat, when enabled, considers any modules inside any$lib/**/server/**directory a server module, rather than just$lib/server/**.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits