Integrate libmesode differences#186
Merged
Merged
Conversation
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
sjaeckel
force-pushed
the
integrate-libmesode-differences
branch
from
e490d01 to
ed6f8ac
Compare
pasis
reviewed
Oct 27, 2021
pasis
left a comment
pasis
left a comment
Member
There was a problem hiding this comment.
Please handle getline() issue and I will merge it.
Member
|
I had a quick look without deep dive into openssl/gnutls code and it looks good. Thanks for the PR. |
Member
Do you think you could create a new release afterwards? |
Member
Sure, I don't have other pending changes. |
sjaeckel
force-pushed
the
integrate-libmesode-differences
branch
from
ed6f8ac to
e639acd
Compare
Based on the differences to libmesode this functionality has been added. It allows a library-user to set a callback for cases where the TLS stack can't verify a received certificate and let the end-user decide what to do. examples/basic implements an example handler of said functionality. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
sjaeckel
force-pushed
the
integrate-libmesode-differences
branch
from
e639acd to
220f276
Compare
pasis
reviewed
Oct 28, 2021
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
sjaeckel
force-pushed
the
integrate-libmesode-differences
branch
from
c156063 to
bf1348e
Compare
Member
|
Merged, thanks |
Member
|
0.11.0 is released. |
Member
Author
|
thx for the review and fast handling! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the major functional difference of
libmesode(the manual verification of a certificate) tolibstrophe.I've re-worked the API's and implementation a bit, but functionality-wise it should be comparable.
The major difference of the implementation is the
libmesodebehavior where processing a certificate will lead to accepting the next presented certificate. This has to be implemented in the application now.