fix: switch to cross-fetch from request

[strmer15]

Motivation and Context

This library currently uses the request library for its CLI usage, but request has been deprecated for over 2 years, which means that all projects that depend on it also install request, which includes all users of @stoplight/prism-cli. cross-fetch is an isomorphic implementation of the fetch API that is not deprecated and provides very similar functionality.

Description

I removed the request dependency, added in the cross-fetch dependency, removed yarn.lock and then ran yarn install. I replaced the require('request') with require('node-fetch'), switched the request(...) invocation to fetch(...).then(...).catch(...), and pulled out the common error handling code into a separate function. I uncommented all the CLI tests, fixed them, then ran yarn test to verify they all passed.

How Has This Been Tested?

Ran yarn test to verify everything passed locally, and uncommented the CLI tests to verify they worked.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• This PR's code follows as closely as possible the coding style/guidelines of this project.
• I have added error reporting and followed the error reporting guidelines.
• I have added event tracking and followed the event tracking guidelines.
• I have updated any relevant documentation accordingly to reflect this PR's changes.
• I have added automated tests (unit/integration/e2e/other) to cover my changes.
• All new and existing tests pass locally (excluding flaky CI tests).

[strmer15]

@chohmann Not sure if you can review or someone else can, this would help resolve a lot of dependency pollution in apps like ours that don't use the request library but have it pulled in by @stoplight/prism-cli.

[strmer15]

@marbemac Can you review this or do you know who can? Thanks!

[CGiustiniani]

@marbemac, @wmhilton, @daniel-white, @lottamus, @mmiask Can anybody please review/check this PR as the request package is deprecated for over 2 years now

[daniel-white]

Should we make this use an isomorphic version to run in the browser?

[daniel-white]

where is body coming from now? we'll need to use the response.text() or equivalent here

[strmer15]

Good call - I'll fix that up. I guess I'm too used to Typescript where I would have gotten a type error 😁

[strmer15]

Should be fixed now! I also spent a lot of time making sure the unit tests actually worked - they would pass previously but they weren't actually working due to the way stdout and stderr were being passed back in the test helper function. I added in a test express server that would allow us to verify that fetch is bringing back the correct data.

[strmer15]

Should we make this use an isomorphic version to run in the browser?

@daniel-white Thanks for reviewing! This is a CLI as far as I can tell, so I don't think it will ever run in a browser. That said, I don't mind using cross-fetch if you think it makes sense.

[daniel-white]

@strmer15 cross-fetch would be appreciated - internally we do use this in a browser, so the flexibility there would be be appreciated

[strmer15]

@strmer15 cross-fetch would be appreciated - internally we do use this in a browser, so the flexibility there would be be appreciated

@daniel-white done! Let me know if you have any other concerns with this PR, thanks for reviewing!

[stoplight-bot]

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀