Skip to content

fix: correct bugs and typos in blas/base/cgemv #12192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
May 19, 2026
+8 −8
Merged

fix: correct bugs and typos in blas/base/cgemv #12192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b47c41
fix: correct `beta` scaling and `LDA` validation in `blas/base/cgemv`
claude May 18, 2026
2dbfbfc
docs: fix typos in `blas/base/cgemv`
claude May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/base/cgemv/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ void c_cgemv( const CBLAS_LAYOUT layout, const CBLAS_TRANSPOSE trans, const CBLA

#### c_cgemv_ndarray( trans, M, N, alpha, \*A, sa1, sa2, oa, \*X, sx, ox, beta, \*Y, sy, oy )

Performs one of the matrix-vector operations `Y = α*A*X + β*Y` or `Y = α*A^T*X + β*Y` or `Y = α*A^H*X + β*Y` using indexing alternative semantics and where `α` and `β` are scalars, `X` and `Y` are vectors, and `A` is an `M` by `N` matrix.
Performs one of the matrix-vector operations `Y = α*A*X + β*Y` or `Y = α*A^T*X + β*Y` or `Y = α*A^H*X + β*Y` using alternative indexing semantics and where `α` and `β` are scalars, `X` and `Y` are vectors, and `A` is an `M` by `N` matrix.

```c
#include "stdlib/blas/base/shared.h"
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/blas/base/cgemv/src/cgemv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ void API_SUFFIX(c_cgemv)( const CBLAS_LAYOUT layout, const CBLAS_TRANSPOSE trans
return;
}
if ( strideX == 0 ) {
c_xerbla( 9, "c_cgemv", "Error: invalid argument. Ninth argument must be a nonzero. Value: `%d`.", strideX );
c_xerbla( 9, "c_cgemv", "Error: invalid argument. Ninth argument must be nonzero. Value: `%d`.", strideX );
return;
}
if ( strideY == 0 ) {
c_xerbla( 12, "c_cgemv", "Error: invalid argument. Twelfth argument must be a nonzero. Value: `%d`.", strideY );
c_xerbla( 12, "c_cgemv", "Error: invalid argument. Twelfth argument must be nonzero. Value: `%d`.", strideY );
return;
}
if ( layout == CblasColMajor ) {
Expand All @@ -88,7 +88,7 @@ void API_SUFFIX(c_cgemv)( const CBLAS_LAYOUT layout, const CBLAS_TRANSPOSE trans
} else {
vala = v;
}
if ( LDA < v ) {
if ( LDA < vala ) {
c_xerbla( 7, "c_cgemv", "Error: invalid argument. Seventh argument must be greater than or equal to max(1,%d). Value: `%d`.", vala, LDA );
return;
}
Expand Down
8 changes: 4 additions & 4 deletions lib/node_modules/@stdlib/blas/base/cgemv/src/cgemv_ndarray.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* @param alpha scalar constant
* @param A input matrix
* @param strideA1 stride of the first dimension of `A`
* @param strideA1 stride of the second dimension of `A`
* @param strideA2 stride of the second dimension of `A`
* @param offsetA starting index for `A`
* @param X first input vector
* @param strideX `X` stride length
Expand Down Expand Up @@ -84,11 +84,11 @@ void API_SUFFIX(c_cgemv_ndarray)( const CBLAS_TRANSPOSE trans, const CBLAS_INT M
return;
}
if ( strideX == 0 ) {
c_xerbla( 10, "c_cgemv_ndarray", "Error: invalid argument. Tenth argument must be a nonzero. Value: `%d`.", strideX );
c_xerbla( 10, "c_cgemv_ndarray", "Error: invalid argument. Tenth argument must be nonzero. Value: `%d`.", strideX );
return;
}
if ( strideY == 0 ) {
c_xerbla( 14, "c_cgemv_ndarray", "Error: invalid argument. Fourteenth argument must be a nonzero. Value: `%d`.", strideY );
c_xerbla( 14, "c_cgemv_ndarray", "Error: invalid argument. Fourteenth argument must be nonzero. Value: `%d`.", strideY );
return;
}
ap = (stdlib_complex64_t *)A;
Expand All @@ -113,7 +113,7 @@ void API_SUFFIX(c_cgemv_ndarray)( const CBLAS_TRANSPOSE trans, const CBLAS_INT M
}
// Y = beta * Y
if ( stdlib_base_complex64_is_equal( beta, zero ) ) {
API_SUFFIX(stdlib_strided_cfill_ndarray)( ylen, alpha, Y, strideY, offsetY );
API_SUFFIX(stdlib_strided_cfill_ndarray)( ylen, zero, Y, strideY, offsetY );
} else if ( !stdlib_base_complex64_is_equal( beta, one ) ) {
API_SUFFIX(c_cscal_ndarray)( ylen, beta, Y, strideY, offsetY );
}
Expand Down