Pin actions to commit SHAs and fix stale version comments - #6254
Merged
Conversation
`arduino/setup-task@v2` is a branch, not a tag, so it can move under us at any time. It currently resolves to b91d5d2c, which is already the pin used in e2e-tests.yml — so pinning the other 11 references changes nothing today and makes the repo internally consistent. Four pins carried a trailing version comment naming a different version than the commit they point at. The pin is what executes, so this is an audit problem rather than a functional one, but a wrong comment is worse than none because reviewers trust it. Each corrected value is taken from an existing pin of the identical SHA elsewhere in this repo. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6254 +/- ##
=======================================
Coverage 72.70% 72.71%
=======================================
Files 742 742
Lines 77299 77299
=======================================
+ Hits 56199 56205 +6
+ Misses 17137 17128 -9
- Partials 3963 3966 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Aug 10, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arduino/setup-task@v2is a branch, not a tag. Eleven references across six workflows point at it, so whatever that branch happens to be at run time is what executes in CI. It currently resolves tob91d5d2c96a56797b48ac1e0e89220bf64044611— which is already the pin used ine2e-tests.yml— so pinning the rest to that SHA changes nothing today while removing the mutable-ref exposure and making the repo internally consistent.claude.yml# v1# v1.0.183issue-triage.ymlrelease-notes.yml# v1# v1.0.183issue-triage.ymloperator-ci.yml# pin@v1.12.0# v1.14.0helm-charts-test.ymltest-e2e-lifecycle.yml# pin@v1.12.0# v1.14.0helm-charts-test.ymlNo action is upgraded or downgraded by this PR — every SHA that was already pinned stays exactly as it was.
Part of #6253
Type of change
Test plan
Unit tests (
task test)E2E tests (
task test-e2e)Linting (
task lint-fix)Manual testing (describe below)
Confirmed via the GitHub API that
arduino/setup-taskhas nov2tag —refs/heads/v2is a branch, currently atb91d5d2c, matching the pin already ine2e-tests.yml.Confirmed each corrected comment against an existing unflagged pin of the same SHA in this repo.
actionlintreports nothing new; all workflows still parse as YAML.zizmorunpinned-usesgoes 11 → 0 andref-version-mismatch5 → 1, the remainder being theupload-sarifpin fixed separately in Add zizmor to CI and stop double-running the security scan #6251.Every touched workflow runs on pull requests, so this PR exercises all of them directly.
Does this introduce a user-facing change?
No.
Special notes for reviewers
The six
operator-ci.ymlchanges are the same one-line edit repeated per job.Generated with Claude Code