fix: static Caplet vault configuration - #238
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughVault grants now preserve configuration origins, unresolved Vault references are quarantined during startup, and canonical-equivalent Caplet roots pass lockfile validation. Toolchain metadata, test setup, WebSocket helpers, and runtime smoke checks are also updated. ChangesVault recovery and grant origins
Canonical Caplet roots
Runtime and test maintenance
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Host
participant ConfigLoader
participant VaultResolver
participant WarningSink
Host->>ConfigLoader: load stored and overlay Caplets
ConfigLoader->>VaultResolver: resolve Vault references
VaultResolver-->>ConfigLoader: resolved values or unresolved warnings
ConfigLoader->>WarningSink: forward overlay warnings
ConfigLoader-->>Host: assembled configuration with quarantined Caplets
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ian-pascoe
changed the title
|
| Filename | Overview |
|---|---|
| packages/core/src/config.ts | Tracks quarantined IDs during source merging so lower-precedence definitions remain disabled. |
| packages/core/src/cli.ts | Uses the effective overlay source as the origin of locally created Vault grants. |
| packages/core/src/engine.ts | Passes Vault recovery and warning options through the host-storage configuration loader. |
| packages/core/src/lockfile.ts | Validates existing destinations against the canonical Caplets root. |
Reviews (2): Last reviewed commit: "fix: address vault configuration review" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.github.com/in/867647?s=60&v=4){kind=small}
Preview DeployedLanding: https://pr-238.preview.caplets.dev Built from commit bf4bb6c |
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.omp/lsp.json:
- Around line 3-5: Update the typescript-language-server configuration entry in
.omp/lsp.json to invoke typescript-language-server with the --stdio argument
instead of tsc with --lsp --stdio, ensuring it uses the available LSP executable
and preserves the existing entry structure.
In `@mise.toml`:
- Around line 3-4: Replace the latest toolchain values in the mise configuration
with explicit Node and pnpm versions matching the repository’s Dockerfile,
package manifests, and pinned pnpm metadata. Keep both tool definitions present
and aligned with those declared requirements.
In `@package.json`:
- Around line 74-76: Restore the repository-wide pnpm pin to 11.7.0: update
package.json, Dockerfile, apps/catalog/package.json, and apps/docs/package.json
so the packageManager values and Docker PNPM_VERSION are all aligned with that
version.
In `@packages/core/src/engine.ts`:
- Around line 194-198: Update CapletsEngine.create() to forward
options.vaultRecoveryTarget in the options object passed to
loadConfigWithHostStorage, preserving the caller-selected recovery target for
both startup and reload.
In `@packages/core/test/serve-http.test.ts`:
- Around line 5507-5525: Update the socket event handling around
nextSocketJson() so the close event uses the same queue-failure logic as the
error event: record the close error/state in queue.error and reject all pending
queue.waiters. Preserve the existing error handling and outcome queuing
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9d1f18b6-a0a7-45c3-be4f-4a125ad156e0
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (25)
.changeset/calm-vault-origins.md.gitignore.omp/lsp.jsonDockerfileapps/catalog/package.jsonapps/dashboard/src/components/DashboardApp.test.tsxapps/dashboard/vitest.config.tsapps/docs/package.jsonmise.tomlpackage.jsonpackages/cli/package.jsonpackages/core/package.jsonpackages/core/src/cli.tspackages/core/src/config.tspackages/core/src/engine.tspackages/core/src/lockfile.tspackages/core/test/caplets-lockfile.test.tspackages/core/test/cli.test.tspackages/core/test/engine.test.tspackages/core/test/host-storage-config.test.tspackages/core/test/native-remote.test.tspackages/core/test/serve-http.test.tspackages/core/test/setup-env.tsscripts/check-package-runtime.mjsscripts/package-runtime-plan-000-smoke.mjs
💤 Files with no reviewable changes (2)
- packages/core/package.json
- packages/cli/package.json
1 participant
Summary
Verification
pnpm verifyRelease
@caplets/coreSummary by CodeRabbit
Bug Fixes
Chores