feat: Add note about hooks to docs (DEV-1214) - #245
Conversation
WalkthroughA documentation update was added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/LIQUIDITY_OPERATIONS.md`:
- Line 72: Clarify the term "hookless" by replacing the ambiguous wording with a
precise condition: state that a pool is considered hookless when its hooks
address equals the zero address (0x000...000) or when the pool reports "no hooks
configured" according to the Uniswap V4 pool spec; update the sentence
referencing `hookData` and onboarding to explicitly check the pool's hooks
address (or the Uniswap V4 "no hooks configured" indicator) before allowing
onboarding so decisions are unambiguous.
|
|
||
| - Only 1:1 stablecoin pools can be onboarded | ||
| - Tick limits must be configured. | ||
| - Only hookless pools can be onboarded. Rate limit decreases are calculated from token balance differences before and after pool interactions, and empty `hookData` is passed. Pool hooks (if present) could manipulate token balances during the call to bypass the rate limit decrease. |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Define “hookless” precisely to avoid ambiguity.
Recommend specifying the exact condition (e.g., hooks address equals zero or “no hooks configured” per Uniswap V4 pool spec) so onboarding decisions are unambiguous.
🤖 Prompt for AI Agents
In `@docs/LIQUIDITY_OPERATIONS.md` at line 72, Clarify the term "hookless" by
replacing the ambiguous wording with a precise condition: state that a pool is
considered hookless when its hooks address equals the zero address (0x000...000)
or when the pool reports "no hooks configured" according to the Uniswap V4 pool
spec; update the sentence referencing `hookData` and onboarding to explicitly
check the pool's hooks address (or the Uniswap V4 "no hooks configured"
indicator) before allowing onboarding so decisions are unambiguous.
|
Coverage after merging dev-1214-docs-addition into dev will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
2 participants
Summary by CodeRabbit