fix: Missing return for ILiquidityPoolLike.deposit

[deluca-mike]

Summary by CodeRabbit

Release Notes

• New Features

  • Deposit functionality now returns the share amount to callers, enabling better transaction tracking.

• Style

  • Fixed whitespace formatting in function signatures.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• MainnetController.sol: The primary functionality remains unchanged; only formatting was adjusted by removing extra spaces.
• WeETHLib.sol: The deposit function now returns uint256 shareAmount instead of having no return value.

---

🔗 Commit Hash: bbbb03b

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

Walkthrough

This pull request updates the interface signature for the deposit function in ILiquidityPoolLike to explicitly return a uint256 shareAmount, alongside a minor whitespace formatting adjustment in MainnetController.sol. No functional logic changes are introduced.

Changes

Cohort / File(s)	Summary
Interface Signature Update src/libraries/WeETHLib.sol	Updated ILiquidityPoolLike deposit function to return uint256 shareAmount instead of void, enabling callers to receive the deposited share amount
Whitespace Formatting src/MainnetController.sol	Whitespace reformatting in requestWithdrawFromWeETH function signature; no semantic changes to return type or visibility

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• [DEV-1041] : Add weETH integration #215 — Directly modifies ILiquidityPool(-Like) deposit() interface in src/libraries/WeETHLib.sol with matching weETH integration changes

Suggested reviewers

• lucas-manuel

Poem

🐰 A whisker-twitch of return types new,
The deposit dance now returns what's due,
Share amounts flow from liquid pools so true,
While whitespace aligns in morning dew,
Small changes bloom in code so clean! 🌱

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: Missing return for ILiquidityPoolLike.deposit' correctly describes the main change: adding a return type to the deposit function signature in the ILiquidityPoolLike interface.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/weth-lib-deposit-returns

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[octane-security-app]

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉

---

🔗 Commit Hash: bbbb03b

[github-actions]

Coverage after merging fix/weth-lib-deposit-returns into dev will be

99.40%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	94.90%	84.62%	95.65%	97.22%	128–129, 129, 129, 316–317, 573
MainnetController.sol	99.18%	100%	98.36%	99.24%	583–584
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WeEthModule.sol	92.86%	75%	100%	100%	26, 38
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	96%	75%	100%	100%	108
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.32%	95.65%	100%	100%	282
WeETHLib.sol	100%	100%	100%	100%