feat: Tighter UniswapV4 types

[deluca-mike]

Summary by CodeRabbit

• Refactor

  • Updated parameter types for Uniswap V4 liquidity operations to use 128-bit integer types for amount values in maximum and minimum amount parameters.
  • Standardized parameter types across mint position, increase liquidity, and decrease liquidity operations.
  • Updated corresponding library functions to propagate type changes.

• Tests

  • Updated test cases and helper functions to align with parameter type changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• MainnetController.sol: Changed amount0Max, amount1Max, amount0Min, and amount1Min data types from uint256 to uint128.
• UniswapV4Lib.sol: The smart contract modifications have changed amount0Max, amount1Max, amount0Min, and amount1Min from uint256 to uint128.

---

🔗 Commit Hash: 68351e0

[octane-security-app]

Overview

Vulnerabilities found:	1

Warnings found:	1

---

🔗 Commit Hash: 68351e0
🛡️ Octane Dashboard: All vulnerabilities

[coderabbitai]

Walkthrough

Parameter types narrowed from uint256 to uint128 for amount fields in Uniswap V4 functions (mintPosition, increasePosition, decreasePosition) across the MainnetController, library, and test files. Function bodies and control flow remain unchanged.

Changes

Cohort / File(s)	Summary
Uniswap V4 Interface Narrowing src/MainnetController.sol, src/libraries/UniswapV4Lib.sol	Parameter types narrowed: amount0Max, amount1Max, amount0Min, amount1Min converted from uint256 to uint128 in mintPositionUniswapV4, increaseLiquidityUniswapV4, and decreaseLiquidityUniswapV4 methods and corresponding library functions. Call sites updated to pass matching parameter types.
Test Utilities test/mainnet-fork/Uniswapv4.t.sol	Helper function signatures updated to reflect uint128 parameters and return types (e.g., _getIncreasePositionMaxAmounts, _quoteLiquidity, _decreasePosition). Casting and variable assignments adjusted accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat: Apply Tick Checks on increaseLiquidityUniswapV4 (SC-1262) #197: Modifies the same Uniswap V4 function signatures (mintPosition/increasePosition/decreasePosition) and corresponding MainnetController wrappers.
• feat: UniswapV4 mint/increase/decrease liquidity support #189: This PR directly updates Uniswap V4 function signatures that were originally added in this PR.

Suggested reviewers

• supercontracts

Poem

🐰 A rabbit hops through types so grand,
Where 256 bits once did stand—
Now 128 brings tighter bounds,
Our V4 dances with cleaner rounds,
Precision whispers, math refined! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The pull request title 'feat: Tighter UniswapV4 types' follows the required format (prefix with colon), is concise, and accurately describes the main change of narrowing parameter types from uint256 to uint128 in Uniswap V4-related functions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/uniswap-uint128

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Coverage after merging feat/uniswap-uint128 into dev will be

99.40%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	94.90%	84.62%	95.65%	97.22%	128–129, 129, 129, 316–317, 573
MainnetController.sol	99.18%	100%	98.36%	99.24%	583–584
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WeEthModule.sol	92.86%	75%	100%	100%	26, 38
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	96%	75%	100%	100%	108
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.32%	95.65%	100%	100%	282
WeETHLib.sol	100%	100%	100%	100%