Mark skipped jobs as successful (#287). - #286
Open
ivanperez-keera wants to merge 1 commit into
Open
Conversation
ivanperez-keera
force-pushed
the
develop-ci-successful-skipped
branch
from
August 17, 2026 17:53
1cc8c86 to
7fde3ee
Compare
ivanperez-keera
changed the title
ivanperez-keera
requested review from
EzraBrooks,
JWhitleyWork,
asimonov and
robwoolley
August 17, 2026 17:54
Some of the CI jobs may be skipped if no files have changed in the MoveIt2 or Nav2 directories. That is causing PRs to be blocked because skipped jobs are not considered successful, and those CI jobs are required before PRs can be merged (without bypassing the rules). This commit modifies the CI workflow that controls the demos to introduce new jobs using the names of the jobs required to pass before PRs can be merged. The new jobs act as proxies, succeeding if the actual CI jobs that build those demos pass or if they are skipped. Introducing these proxies, which use the names that the jobs that actually build the demos used before, prevents PRs from being blocked indefinitely when a CI job doesn't build because no files from that demo have been modified.
ivanperez-keera
force-pushed
the
develop-ci-successful-skipped
branch
from
August 17, 2026 21:15
7fde3ee to
6284a70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot merge PRs without forcing them because some PRs do not touch moveit2 or nav2 and the CI jobs are not considered successful if they are skipped.
This PR modifies the workflow file to add logic that detects if the workflow was skipped, in which case it's considered
successful.
Fixes #287.