servegit: use service from sourcegraph/lib - #557
Merged
Conversation
LawnGnome
approved these changes
Jun 22, 2021
LawnGnome
left a comment
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
LGTM, and I appreciate the other dependency updates as well. 👍
keegancsmith
commented
Jun 23, 2021
This version was duplicated into sourcegraph and then improved. It now has been moved into the shared library for us to use.
keegancsmith
force-pushed
the
k/servegit-dep
branch
from
June 23, 2021 05:36
ce0a3b8 to
6620ddc
Compare
The updated lib dependency uses APIs only in go1.16. So we need to drop support for 1.15 for CI to work.
Member
Author
|
@LawnGnome FYI I dropped support for go1.15 on CI. I requested re-review just to confirm that is fine :) |
eseliger
approved these changes
Jun 23, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This version was duplicated into sourcegraph and then improved. It now has been moved into the shared library for us to use. Note: The updated lib dependency uses APIs only in go1.16. So we need to drop support for 1.15 for CI to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version was duplicated into sourcegraph and then improved. It now
has been moved into the shared library for us to use.
For context see #547 (review)