Add flag to insecurely skip certificate validation - #475
Merged
Conversation
4 tasks
LawnGnome
approved these changes
Feb 22, 2021
LawnGnome
left a comment
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I particularly appreciate putting insecure in the flag name!
| dump: flagSet.Bool("dump-requests", false, "Log GraphQL requests and responses to stdout"), | ||
| getCurl: flagSet.Bool("get-curl", false, "Print the curl command for executing this query and exit (WARNING: includes printing your access token!)"), | ||
| trace: flagSet.Bool("trace", false, "Log the trace ID for requests. See https://docs.sourcegraph.com/admin/observability/tracing"), | ||
| insecureSkipVerify: flagSet.Bool("insecure-skip-verify", false, "Skip validating x.509 certificates against trusted chains"), |
Contributor
There was a problem hiding this comment.
Although X.509 is more technically correct, I think we should put TLS in there instead:
Suggested change
| insecureSkipVerify: flagSet.Bool("insecure-skip-verify", false, "Skip validating x.509 certificates against trusted chains"), | |
| insecureSkipVerify: flagSet.Bool("insecure-skip-verify", false, "Skip validation of TLS certificates against trusted chains"), |
Member
Author
There was a problem hiding this comment.
yeah, I was inspired too much by the error message I was trying to overcome, I guess 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optional flag to disable certificate validation. Given that, I think it should fix #463. I don't know how I feel about this, but it seems to work ok: