update Go version; add websocket / correct endpoints to 'src gateway benchmark' - #1125
Merged
Conversation
vdavid
approved these changes
Nov 15, 2024
vdavid
left a comment
vdavid
left a comment
Contributor
There was a problem hiding this comment.
Approved to unblock and because it's generally 👌. Also left a few suggestions to improve it further before merging.
vdavid
reviewed
Nov 15, 2024
camdencheek
approved these changes
Nov 20, 2024
camdencheek
left a comment
camdencheek
left a comment
Contributor
There was a problem hiding this comment.
Didn't review the changes to src gateway benchmark closely, but stamping on behalf of the code search team for the version bumps. Thanks!
added 4 commits
December 3, 2024 16:19
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues development of #1124
/.api/gatewayand/.api/gateway/websocket./v2and/v2/websocket-gatewayparameter andSRC_ENDPOINT/SRC_ACCESS_TOKENThis should be sufficient for testing against the actual production endpoints once they are added / working / live in prod.
Test plan
Not tested yet since endpoints are not live yet. Command not in use yet, so no risk.