fix(web): Ask sourcebot perf improvements by brendan-kellam · Pull Request #632 · sourcebot-dev/sourcebot

brendan-kellam · 2025-11-26T07:42:39Z

Improves Ask mode performance by adding memoization in various places + some other optimizations

Fixes #626

coderabbitai · 2025-11-26T07:42:54Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch bkellam/chat_perf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

brendan-kellam · 2025-11-29T05:34:14Z

@coderabbitai A user has raised that they are hitting a 404 error when getting redirected to localhost:3000/~/chat/. I believe this is a regression that was introduced in this PR. Please find the issue.

coderabbitai · 2025-11-29T05:35:10Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get the details of PR #632 including files changed
gh pr view 632 --json files,title,body --jq '.files[] | .path'

Length of output: 1589

🏁 Script executed:

#!/bin/bash
# Get the diff for PR #632 to see what was changed
gh pr diff 632

Length of output: 87353

@brendan-kellam I found the regression! The issue is that several client-side navigation calls were changed to use the hardcoded SINGLE_TENANT_ORG_DOMAIN constant (which is ~) instead of the actual domain from useDomain() hook.

Root Cause

The Next.js app structure uses [domain] as a dynamic route parameter (e.g., app/[domain]/chat/[id]/page.tsx). When users navigate to chat routes, the code now redirects to /~/chat/<hash> instead of using the user's actual domain, causing a 404 error.

Affected Files

1. packages/web/src/features/chat/useCreateNewChatThread.ts (Lines 49-50)

// BEFORE (correct):
const url = createPathWithQueryParams(`/${domain}/chat/${response.id}`);

// AFTER (broken):
const url = createPathWithQueryParams(`/${SINGLE_TENANT_ORG_DOMAIN}/chat/${response.id}`);

2. packages/web/src/app/[domain]/chat/components/chatSidePanel.tsx (Lines 106, 133, 147, 165)

// Multiple instances where navigation now uses SINGLE_TENANT_ORG_DOMAIN:
router.push(`/${SINGLE_TENANT_ORG_DOMAIN}/chat`);
router.push(`/${SINGLE_TENANT_ORG_DOMAIN}/chat/${chat.id}`);

3. packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx (Line 179)

const url = createPathWithQueryParams(`/${SINGLE_TENANT_ORG_DOMAIN}/search`, ...);

4. packages/web/src/features/chat/components/chatThread/tools/searchCodeToolComponent.tsx (Line 80)

href={createPathWithQueryParams(`/${SINGLE_TENANT_ORG_DOMAIN}/search`, ...)}

5. packages/web/src/features/chat/components/chatThread/tools/shared.tsx (Line 29)

domain: SINGLE_TENANT_ORG_DOMAIN,

Solution

These files need to be reverted to use useDomain() hook for client-side navigation. The SINGLE_TENANT_ORG_DOMAIN constant should only be used on the server-side where the domain context is guaranteed, not for client-side routing where the actual domain may vary.

Would you like me to create an issue to track this fix?

brendan-kellam · 2025-11-29T05:36:41Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Get the details of PR #632 including files changed
gh pr view 632 --json files,title,body --jq '.files[] | .path'
Length of output: 1589

🏁 Script executed:
#!/bin/bash
# Get the diff for PR #632 to see what was changed
gh pr diff 632
Length of output: 87353

@brendan-kellam I found the regression! The issue is that several client-side navigation calls were changed to use the hardcoded SINGLE_TENANT_ORG_DOMAIN constant (which is ~) instead of the actual domain from useDomain() hook.

Root Cause

The Next.js app structure uses [domain] as a dynamic route parameter (e.g., app/[domain]/chat/[id]/page.tsx). When users navigate to chat routes, the code now redirects to /~/chat/<hash> instead of using the user's actual domain, causing a 404 error.

Affected Files

1. packages/web/src/features/chat/useCreateNewChatThread.ts (Lines 49-50)
// BEFORE (correct):
const url = createPathWithQueryParams(`/${domain}/chat/${response.id}`);

// AFTER (broken):
const url = createPathWithQueryParams(`/${SINGLE_TENANT_ORG_DOMAIN}/chat/${response.id}`);
2. packages/web/src/app/[domain]/chat/components/chatSidePanel.tsx (Lines 106, 133, 147, 165)
// Multiple instances where navigation now uses SINGLE_TENANT_ORG_DOMAIN:
router.push(`/${SINGLE_TENANT_ORG_DOMAIN}/chat`);
router.push(`/${SINGLE_TENANT_ORG_DOMAIN}/chat/${chat.id}`);
3. packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx (Line 179)
const url = createPathWithQueryParams(`/${SINGLE_TENANT_ORG_DOMAIN}/search`, ...);
4. packages/web/src/features/chat/components/chatThread/tools/searchCodeToolComponent.tsx (Line 80)
href={createPathWithQueryParams(`/${SINGLE_TENANT_ORG_DOMAIN}/search`, ...)}
5. packages/web/src/features/chat/components/chatThread/tools/shared.tsx (Line 29)
domain: SINGLE_TENANT_ORG_DOMAIN,
Solution

These files need to be reverted to use useDomain() hook for client-side navigation. The SINGLE_TENANT_ORG_DOMAIN constant should only be used on the server-side where the domain context is guaranteed, not for client-side routing where the actual domain may vary.

Would you like me to create an issue to track this fix?

@coderabbitai this is not the issue.

coderabbitai · 2025-11-29T05:39:30Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get the list of files that were added, deleted, or modified in PR #632
echo "=== Files Added/Deleted/Modified in PR #632 ==="
gh pr view 632 --json files --jq '.files[] | "\(.changeType): \(.path)"'

echo ""
echo "=== Looking for chat route related files ==="
gh pr view 632 --json files --jq '.files[] | select(.path | contains("chat")) | "\(.changeType): \(.path)"'

Length of output: 3173

🏁 Script executed:

#!/bin/bash
# Check if the chat/[id]/page.tsx file still exists and examine its content
echo "=== Checking for chat dynamic route page files ==="
fd -t f "page.tsx" --full-path "chat" | head -20

echo ""
echo "=== Examining the chat [id] page structure ==="
fd -t f --glob "**/chat/**/page.tsx" --exec echo {}

Length of output: 190

🏁 Script executed:

#!/bin/bash
# Let's look at the specific diff for chat route page files
echo "=== Getting diff for chat dynamic route pages ==="
gh pr diff 632 -- "**/chat/**/page.tsx" | head -200

Length of output: 86

🏁 Script executed:

#!/bin/bash
# Check if there were any changes to middleware or layout files that could affect routing
echo "=== Checking for middleware changes ==="
gh pr view 632 --json files --jq '.files[] | select(.path | contains("middleware")) | "\(.changeType): \(.path)"'

echo ""
echo "=== Checking for layout changes in chat routes ==="
gh pr view 632 --json files --jq '.files[] | select(.path | contains("layout")) | "\(.changeType): \(.path)"'

Length of output: 91

🏁 Script executed:

#!/bin/bash
# Get the full diff for the chat [id] page file
echo "=== Diff for packages/web/src/app/[domain]/chat/[id]/page.tsx ==="
gh pr diff 632 | grep -A 100 -B 5 "diff --git a/packages/web/src/app/\[domain\]/chat/\[id\]/page.tsx"

Length of output: 4935

🏁 Script executed:

#!/bin/bash
# Let's look at the current content of the chat [id] page
echo "=== Current content of chat [id] page.tsx ==="
cat packages/web/src/app/[domain]/chat/[id]/page.tsx

Length of output: 3313

🏁 Script executed:

#!/bin/bash
# Check if there's a base chat page.tsx (without [id])
echo "=== Looking for all chat-related page.tsx files ==="
find packages/web/src/app -name "page.tsx" -path "*chat*" -exec echo "File: {}" \; -exec head -20 {} \;

Length of output: 1962

🏁 Script executed:

#!/bin/bash
# Let's examine the specific changes to useCreateNewChatThread which handles navigation
echo "=== Changes to useCreateNewChatThread.ts ==="
gh pr diff 632 | grep -A 50 -B 10 "diff --git a/packages/web/src/features/chat/useCreateNewChatThread.ts"

Length of output: 2985

🏁 Script executed:

#!/bin/bash
# Let's look at the changes to the chat actions.ts file, particularly getChatInfo and getUserChatHistory
echo "=== Changes to features/chat/actions.ts ==="
gh pr diff 632 | grep -A 150 "diff --git a/packages/web/src/features/chat/actions.ts"

Length of output: 5958

🏁 Script executed:

#!/bin/bash
# Let's check what SINGLE_TENANT_ORG_DOMAIN is defined as
echo "=== Looking for SINGLE_TENANT_ORG_DOMAIN definition ==="
rg -n "SINGLE_TENANT_ORG_DOMAIN\s*=" packages/web/src/lib/constants.ts

Length of output: 103

🏁 Script executed:

#!/bin/bash
# Let's check if there are any middleware or routing rewrites that handle the ~ domain
echo "=== Checking for middleware files ==="
find packages/web -name "middleware.ts" -o -name "middleware.js" | head -5

echo ""
echo "=== Checking next.config files ==="
find packages/web -name "next.config.*" | head -5

Length of output: 133

🏁 Script executed:

#!/bin/bash
# Let's see the full implementation of getChatInfo and getUserChatHistory after the changes
echo "=== Current implementation of getChatInfo ==="
cat packages/web/src/features/chat/actions.ts | grep -A 30 "export.*getChatInfo"

Length of output: 1037

🏁 Script executed:

#!/bin/bash
# Let's examine the withOptionalAuthV2 implementation to see how it determines the org
echo "=== Looking for withOptionalAuthV2 implementation ==="
cat packages/web/src/withAuthV2.ts

Length of output: 5626

🏁 Script executed:

#!/bin/bash
# Let's check the middleware to see if it handles domain resolution
echo "=== Checking middleware.ts ==="
cat packages/web/src/middleware.ts

Length of output: 1366

🏁 Script executed:

#!/bin/bash
# Let's see if withOptionalAuthV2 was added or modified in this PR
echo "=== Changes to withAuthV2 in PR #632 ==="
gh pr diff 632 | grep -B 5 -A 100 "diff --git a/packages/web/src/withAuthV2.ts"

Length of output: 40

🏁 Script executed:

#!/bin/bash
# Let's check if there were any other server action functions that had domain parameter removed
echo "=== Looking for getUserChatHistory changes ==="
gh pr diff 632 | grep -B 10 -A 30 "getUserChatHistory"

Length of output: 4107

🏁 Script executed:

#!/bin/bash
# Let's check what SINGLE_TENANT_ORG_ID is defined as
echo "=== Looking for SINGLE_TENANT_ORG_ID definition ==="
rg -n "SINGLE_TENANT_ORG_ID\s*=" packages/web/src/lib/constants.ts

Length of output: 93

🏁 Script executed:

#!/bin/bash
# Let's see if withAuthV2 file was present before this PR or if it's new
echo "=== Checking if withAuthV2.ts was added in this PR ==="
gh pr view 632 --json files --jq '.files[] | select(.path | contains("withAuthV2")) | "\(.changeType): \(.path)"'

Length of output: 54

🏁 Script executed:

#!/bin/bash
# Let's look at how the old withOrgMembership worked - what did it do with the domain parameter?
echo "=== Looking for withOrgMembership implementation ==="
rg -n -A 20 "withOrgMembership\s*=" packages/web/src/actions.ts

Length of output: 713

🏁 Script executed:

#!/bin/bash
# Let's check if getSearchContexts still takes domain parameter
echo "=== Checking getSearchContexts signature ==="
rg -n "export.*getSearchContexts" packages/web/src/actions.ts
cat packages/web/src/actions.ts | grep -A 15 "export.*getSearchContexts"

Length of output: 708

🏁 Script executed:

#!/bin/bash
# Let's verify that getSearchContexts was NOT updated in this PR but is still being called with params.domain
echo "=== Check if getSearchContexts was modified in PR #632 ==="
gh pr diff 632 | grep -B 5 -A 30 "getSearchContexts"

Length of output: 2113

🏁 Script executed:

#!/bin/bash
# Let's check what the actual org domain should be - look at the org table structure
echo "=== Looking for org domain examples or schema ==="
rg -n "domain.*string" packages/web/src --type ts -g "*schema*" | head -10

Length of output: 49

🏁 Script executed:

#!/bin/bash
# Let's see all the places where params.domain is passed to server actions in the chat page
echo "=== All uses of params.domain in chat [id] page ==="
cat packages/web/src/app/[domain]/chat/[id]/page.tsx | grep -n "params.domain"

Length of output: 218

🏁 Script executed:

#!/bin/bash
# Let's check if there are other pages that might have the same issue
echo "=== Checking other pages for similar patterns ==="
fd -e tsx "page.tsx" packages/web/src/app --exec grep -l "getSearchContexts" {}

Length of output: 142

🏁 Script executed:

#!/bin/bash
# Let's check what the chat landing page (without [id]) does
echo "=== Checking chat landing page ==="
cat packages/web/src/app/[domain]/chat/page.tsx | grep -n "getSearchContexts\|params.domain"

Length of output: 220

🏁 Script executed:

#!/bin/bash
# Let's find all server actions in actions.ts that still use withOrgMembership and take domain parameter
echo "=== Finding all functions still using old withOrgMembership pattern ==="
rg -n "withOrgMembership.*domain" packages/web/src/actions.ts | head -20

Length of output: 1568

🏁 Script executed:

#!/bin/bash
# Let's check if there's an actual org with a real domain in the system
echo "=== Looking for how orgs are seeded/created ==="
fd -e ts -e sql "seed" packages/web | head -5

Length of output: 47

🏁 Script executed:

#!/bin/bash
# Let's look at the TopBar component to see if it's also affected
echo "=== Checking TopBar component usage ==="
cat packages/web/src/app/[domain]/components/topBar.tsx | head -50

Length of output: 1610

@brendan-kellam I found the actual regression! The issue is an incomplete migration in PR #632.

Root Cause

The PR migrated several chat-related server actions from the old withOrgMembership(userId, domain, ...) pattern to the new withAuthV2/withOptionalAuthV2 pattern. However, getSearchContexts was not migrated, and it's still being called with params.domain.

Here's what happens:

The call in packages/web/src/app/[domain]/chat/[id]/page.tsx (Line 26):
```
const searchContexts = await getSearchContexts(params.domain);
```
Where params.domain = "~" (the routing constant)

getSearchContexts in actions.ts (Line 1655) still uses the old pattern:

export const getSearchContexts = async (domain: string) => sew(() =>
    withAuth((userId) =>
        withOrgMembership(userId, domain, async ({ org }) => {

withOrgMembership tries to look up the org by domain:

const org = await prisma.org.findUnique({
    where: {
        domain,  // domain = "~"
    },
});

No org exists with domain "~" (it's just a routing constant), so it returns notFound(), causing the 404 error.

Why other functions work

Functions like getChatInfo and getUserChatHistory were successfully migrated to use withAuthV2/withOptionalAuthV2, which look up the org by hardcoded ID instead:

const org = await __unsafePrisma.org.findUnique({
    where: {
        id: SINGLE_TENANT_ORG_ID,  // id = 1
    }
});

Solution

getSearchContexts needs to be migrated to use the new auth pattern (like the other functions were), and the calls to it need to stop passing the domain parameter:

Update getSearchContexts in actions.ts to use withAuthV2
Remove the domain parameter from the function signature
Update calls in:
- packages/web/src/app/[domain]/chat/[id]/page.tsx (Line 26)
- packages/web/src/app/[domain]/chat/page.tsx (Line 25)

Would you like me to create an issue to track this fix?

This comment has been minimized.

Sign in to view

brendan-kellam commented Nov 26, 2025

View reviewed changes

Comment thread packages/web/src/features/chat/components/chatThread/chatThread.tsx Outdated

brendan-kellam commented Nov 26, 2025

View reviewed changes

Comment thread packages/web/src/features/chat/components/chatThread/referencedFileSourceListItem.tsx Outdated

github-advanced-security AI found potential problems Nov 26, 2025

View reviewed changes

Comment thread packages/web/src/features/chat/actions.ts Dismissed

brendan-kellam added 3 commits November 27, 2025 14:25

fix bug with file @ mentions

cbe381a

wip on perf optimizations. Also changed some actions to withAuthV2

3863f6d

fix permissions on audit endpoint

da3c93e

brendan-kellam force-pushed the bkellam/chat_perf branch from 8ad6960 to da3c93e Compare November 27, 2025 22:25

brendan-kellam added 3 commits November 27, 2025 16:05

memoize all of the things

4b7798a

add back scroll restoration

64e6350

nit & changelog

95c12a1

brendan-kellam merged commit f1dd16b into main Nov 28, 2025
8 checks passed

brendan-kellam deleted the bkellam/chat_perf branch November 28, 2025 00:56

github-actions Bot mentioned this pull request Nov 28, 2025

Sourcebot Roadmap 🚀 #459

Open

Navigation Menu

Uh oh!

fix(web): Ask sourcebot perf improvements - #632

fix(web): Ask sourcebot perf improvements#632
brendan-kellam merged 6 commits into
mainfrom
bkellam/chat_perf

brendan-kellam commented Nov 26, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

coderabbitai Bot commented Nov 26, 2025 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brendan-kellam commented Nov 29, 2025

Uh oh!

coderabbitai Bot commented Nov 29, 2025

Uh oh!

brendan-kellam commented Nov 29, 2025

Root Cause

Affected Files

Solution

Uh oh!

coderabbitai Bot commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

brendan-kellam commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

coderabbitai Bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brendan-kellam commented Nov 29, 2025

Uh oh!

coderabbitai Bot commented Nov 29, 2025

Root Cause

Affected Files

Solution

Uh oh!

brendan-kellam commented Nov 29, 2025

Root Cause

Affected Files

Solution

Uh oh!

coderabbitai Bot commented Nov 29, 2025

Root Cause

Why other functions work

Solution

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brendan-kellam commented Nov 26, 2025 •

edited

Loading

coderabbitai Bot commented Nov 26, 2025 •

edited

Loading