Skip to content

Fix nmos-cpp-registry and nmos-cpp-node startup without config JSON#499

Merged
lo-simon merged 1 commit into
sony:masterfrom
lo-simon:fix-startup
Jul 1, 2026
Merged

Fix nmos-cpp-registry and nmos-cpp-node startup without config JSON#499
lo-simon merged 1 commit into
sony:masterfrom
lo-simon:fix-startup

Conversation

@lo-simon

@lo-simon lo-simon commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Thank you to Niitsu, Keita-san from Sony, for reporting this issue, as no config JSON is provided to start nmos-cpp-registry and nmos-cpp-node.

Issue:

  1. registry_model.settings/node_model.settings are default-constructed as null.
  2. When no command-line arguments are supplied, no settings are loaded.
  3. validate_registry_settings/validate_node_implementation_settings are called with a null JSON value.
  4. Schema validation fails because the root type is not an object.

Solution:

  • Initialise settings as an empty JSON object in base_model (nmos/model.h).

… nmos-cpp-registry to start without a config JSON

@jonathan-r-thorpe jonathan-r-thorpe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit 51d0ea6 into sony:master Jul 1, 2026
10 checks passed
@lo-simon lo-simon deleted the fix-startup branch July 1, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants