fix: enum default encode with - #14
Merged
Merged
Conversation
coolme200
commented
Jan 28, 2019
| gen('encoder.writeInt(1);'); | ||
| gen('encoder.writeString(\'name\');'); | ||
| gen('encoder._writeObjectBegin(\'%s\'); }', type); | ||
| gen('encoder.writeString(typeof obj.name === \'string\' ? obj.name : obj);'); |
Collaborator
Author
There was a problem hiding this comment.
原先这里判断是否 string 其实没必要的，如果 obj 不是 string 呢 还是会出问题
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 446 446
=====================================
Hits 446 446
Continue to review full report at Codecov.
|
Member
|
这个应该算是个 feature 吧 |
Member
|
1.2.0 |
Member
|
+ coolme200 (sofa-hessian-node) |
coolme200
added a commit
to node-modules/js-to-java
that referenced
this pull request
Jan 29, 2019
coolme200
added a commit
to node-modules/js-to-java
that referenced
this pull request
Jan 29, 2019
coolme200
added a commit
to node-modules/js-to-java
that referenced
this pull request
Jan 29, 2019
coolme200
added a commit
to node-modules/js-to-java
that referenced
this pull request
Jan 29, 2019
coolme200
added a commit
to node-modules/js-to-java
that referenced
this pull request
Jan 29, 2019
coolme200
added a commit
to node-modules/js-to-java
that referenced
this pull request
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.