Skip to content

ORG_CONTROL -> GH_REQUIRED_CHECK#162

Merged
TomHennen merged 2 commits into
slsa-framework:mainfrom
TomHennen:tweak_required_check_prefix
May 31, 2025
Merged

ORG_CONTROL -> GH_REQUIRED_CHECK#162
TomHennen merged 2 commits into
slsa-framework:mainfrom
TomHennen:tweak_required_check_prefix

Conversation

@TomHennen

Copy link
Copy Markdown
Contributor

This makes it more clear what this thing is. Instead of just any type of control (it's already listed in a thing called controls). It indicates it's a Git Hub Required Check.

If we wanted to we could also uppercase and remove spaces and stuff, but I think it's actually better to more directly use the string used by GitHub.

In the future, if we wanted, we could do something like include extra details in the Controls field in the provenance and then have a nicer name, but that's not a priority right now.

TomHennen added 2 commits May 31, 2025 21:48
Signed-off-by: Tom Hennen <tomhennen@google.com>
Signed-off-by: Tom Hennen <tomhennen@google.com>
@TomHennen
TomHennen merged commit 0532756 into slsa-framework:main May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant