refactor: 주요 flex wrapper를 side Flex로 마이그레이션 - #186
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KYBee
marked this pull request as ready for review
May 31, 2026 08:09
G-hoon
approved these changes
Jun 8, 2026
G-hoon
left a comment
Collaborator
There was a problem hiding this comment.
넵 수고하셨습니다.
추후에 토큰화된 디자인 시스템 적용 시에,
<Flex
...
gap="12px"
이런 값들은 통일되면 좋을 것 같습니다!
Contributor
Author
|
@G-hoon 넵 추후에 토큰 적용까지 해보려 합니다~ 감사합니다 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: side Flex 마이그레이션을 위한 테스트 정리 및 1유형 wrapper 전환
작업 내용
RecruitmentSummary,Badge,ContactSection의 현재 렌더링 계약을 테스트로 먼저 고정했습니다.@sipe-team/side의Flex로 전환했습니다.변경 사항
RecruitmentSummary상태별 렌더링 테스트 추가Badge텍스트 렌더링 테스트 추가ContactSection문의 문구와 이메일 링크 렌더링 테스트 추가RecruitmentSummarytimer wrapperBadgeinline flex wrapperContactSectionwrapper 및 email link wrapperFlexAPI 범위 밖이라 SCSS media query에 유지확인 사항
yarn test통과 (9 files / 16 tests)git diff --check develop..HEAD통과