Skip to content

chore(checkbox): useId를 @sipe-team/hooks로 교체 - #321

Merged
3o14 merged 1 commit into
devfrom
refactor/useid-checkbox-wonju
Aug 4, 2026
Merged

chore(checkbox): useId를 @sipe-team/hooks로 교체#321
3o14 merged 1 commit into
devfrom
refactor/useid-checkbox-wonju

Conversation

@3o14

@3o14 3o14 commented Aug 4, 2026

Copy link
Copy Markdown
Member

요약

Checkbox의 내부 id 생성 방식을 React의 raw useId 대신 @sipe-team/hooksuseId로 교체합니다. Tooltip(#319), Radio/RadioGroup(#320)에 이어 Accordion에 적용된 공유 훅과 동일한 패턴으로 통일하기 위함입니다. 기존 props.id ?? internalId fallback 패턴은 useIddeterministicId 인자가 동일하게 처리하므로 const id = useId(props.id); 한 줄로 대체했습니다. id prop을 명시적으로 넘기지 않을 때 생성되는 id에 side- 접두어가 붙는 것 외에 동작 변화는 없습니다.

변경 사항

  • Checkbox.tsxuseId import를 react에서 @sipe-team/hooks로 교체
  • const internalId = useId(); const id = props.id ?? internalId;const id = useId(props.id);로 축약
  • @sipe-team/checkbox 패키지에 @sipe-team/hooks 의존성 추가
  • patch changeset 추가

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6bf267

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sipe-team/checkbox Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
side Ready Ready Preview Aug 4, 2026 10:26am

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 709d3846-66d5-402a-8f30-2230af26d44a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
packages/checkbox/src/Checkbox.tsx 92.72% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3o14
3o14 merged commit a89462a into dev Aug 4, 2026
8 checks passed
@3o14
3o14 deleted the refactor/useid-checkbox-wonju branch August 4, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants