Add missing manifest files to RescuePatching#929
Merged
Conversation
The base build 1437 (from release/9.3.9) still contains ManagedVwWindow.manifest and SimpleRootSite.manifest, which were removed on main by #906. The existing fix (#909) handled .dll, .dll.config, and .pdb but missed the two .manifest files, causing PYRO0305 errors during patch builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mark-sil
approved these changes
Jun 4, 2026
mark-sil
left a comment
mark-sil
left a comment
Contributor
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManagedVwWindow.dll,.dll.config, and.pdbtoRescuePatchingbut missed two manifest files that were also removed by Retire Linux-era view shims #906ManagedVwWindow.manifestandSimpleRootSite.manifestto theRescuePatchingtarget, fixing PYRO0305 errors during patch builds against base 1437Test plan
🤖 Generated with Claude Code
This change is