feat/project upgrade - #1288
Merged
Merged
Conversation
Soner (shyim)
commented
Jul 29, 2026
Soner (shyim)
commented
Member
- fix: cr review
- refactor: remove redundant project details message from overview report
- chore: enable perfsprint linter and apply its fixes
- feat: add admin dev server port detection and update overview model
fmt.Errorf without verbs becomes errors.New, fmt.Sprintf becomes plain concatenation or strconv. Two intentional swallowed errors in the PHP lint walk (reported as validation warnings instead) are annotated for nilerr, which resurfaced alongside the sweep. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR5veromwFWWyasWLqv4QJ
…te in Shopware 6.6
…e across multiple files - Updated string concatenation in `mysql.go`, `setup.go`, `tab_overview.go`, `tab_overview_health.go`, `filter_multi_select.go`, `filterlist.go`, `panels.go`, `progress_spinner.go`, `scrollbar.go`, `selectlist.go`, `shortcuts.go`, `textfit.go`, `twocolumn.go`, `overlay_extension_detail.go`, `panel_check.go`, `panel_done.go`, `panel_intro.go`, `panel_prepare.go`, `panel_review.go`, and `panel_run.go` to use separate WriteString calls for better clarity. - Replaced instances of `strings.Repeat` and other calculations with `max` and `min` functions for cleaner logic. - Enhanced readability by breaking down complex lines into simpler, more manageable parts.
normalizeStoreLink matched ":80" as a prefix of custom ports like ":8080", corrupting the URL when trimming; it now parses the URL and only rewrites store.shopware.com links on the default ports. Task.finish mutated the local Task through a pointer receiver inside `return t, t.finish()`, where the copy of t as a return operand races the mutation (unspecified evaluation order). finish is now a value receiver returning the updated Task. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR5veromwFWWyasWLqv4QJ
35 tasks
…weep The gopls quickfix invents names like sSb592; rewrite the three affected functions idiomatically (strings.Join for the INSERT column list, a single builder each for the review summary and shortcut bar). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR5veromwFWWyasWLqv4QJ
# Conflicts: # internal/system/setup.go
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR5veromwFWWyasWLqv4QJ
Tomasz Turkowski (tturkowski)
approved these changes
Aug 5, 2026
Tomasz Turkowski (tturkowski)
added a commit
that referenced
this pull request
Aug 6, 2026
…her port Drop the version-gated adminWatchLocalPort in favor of the shared extension.AdminDevServerPort (from #1288), which reads the ADMIN_VITE flag instead of guessing from the Shopware version — correct for a 6.6 shop that opted into Vite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.