[codex] Add generic PR-batch continuation prompt - #49
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review summaryThis PR adds a canonical "Generic PR-Batch Continuation Prompt" to
🤖 Generated with Claude Code |
Review SummaryReviewed the diff for correctness, security, portability, and shell/Ruby helper safety. This is a docs/skills-only change (no behavior in I verified:
Left 3 minor/nit inline comments, nothing blocking:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1cbf9383f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ReviewThis PR adds a canonical, self-contained "Generic PR-Batch Continuation Prompt" to I verified by hand (Bash execution of
One finding, left as an inline comment: the new No security, performance, or shell/Ruby-safety issues found — the script only reads local repo files (no shell-out, no user input, no eval), and no files under |
Review SummaryReviewed the diff (docs/agent-runner-restarts.md, docs/pr-batch-skills.md, skills/plan-pr-batch/SKILL.md, skills/plan-pr-batch/scripts/check_goal_prompt_size.rb, skills/pr-batch/SKILL.md, workflows/pr-processing.md). Overall: This is a docs/prompt-only change (plus a Ruby validation guard) that adds a canonical "Generic PR-Batch Continuation Prompt" and routes several skill docs to it. Portability looks good — no hardcoded consumer-repo commands, labels, branches, or paths were introduced; the placeholder PR numbers ( One inline finding: the new "Terminal states allowed" list in the continuation prompt ( No other bugs, security issues, or performance concerns found — the changes are documentation/prompt text plus a self-contained validation script with no shell/eval risk. |
Review summaryReviewed the diff for correctness, portability, and Ruby helper safety. Portability — The new Ruby helper ( Minor nit (non-blocking) — Note (out of scope for this PR) — No security or performance concerns — this PR only touches Markdown docs and a local validation script that reads repo files; no new external input handling. |
ReviewFocused, low-risk change: adds a canonical saved continuation prompt for PR-batch closeout and hardens Portability — clean. No consumer-repo commands, labels, branches, or release trackers are hardcoded in any of the changed Script correctness ( Nit (pre-existing, unrelated to this diff) — No security, performance, or shell-safety concerns — this PR touches only Markdown prose and one Ruby validation script (no shell scripts), and doesn't shell out, read untrusted input, or write outside the repo. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bca2cbed38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 211f5ba9d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef74558d0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review SummaryThis PR adds a canonical "Generic PR-Batch Continuation Prompt" to Portability check (AGENTS.md "Editing Rules"): the new/changed prose in Two findings from a close read of
Nothing else surfaced that looked like a functional bug — the drift/self-checks in the script appear internally consistent with the doc content on a static read (I wasn't able to execute |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e5123fe43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review SummaryReviewed the diff for portability, shell/Ruby helper safety, and correctness of the new prompt-drift guard. Overall this is solid: the new "Generic PR-Batch Continuation Prompt" content and its Ruby drift-check ( Portability: No hardcoded consumer-repo commands/labels/branches/paths were introduced in Left two inline comments, both low-severity:
Note: I was unable to execute |
Review summaryThis PR adds a canonical, saved-clipboard "Generic PR-Batch Continuation Prompt" to What I checked:
No correctness, security, or performance issues found. One minor nit posted inline: a new bash test doesn't actually exercise the behavior its name implies, since |
Review SummaryReviewed for portability, correctness, shell/Ruby helper safety, and general code quality. Portability: The new "Generic PR-Batch Continuation Prompt" and its routing changes across Design: The Left two inline comments on issues worth addressing:
No security or performance concerns found; shell scripts use |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5efd1c12fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review SummaryReviewed the full diff (docs, skills, Overall: solid, well-scoped change. The new
One non-blocking item left as an inline comment: No security, performance, or portability blockers found. |
Review SummaryReviewed with a focus on correctness, security, performance, portability of shared skills/workflows, and shell/Ruby helper safety. Overall: solid change. The PR does what it says: adds a single canonical "Generic PR-Batch Continuation Prompt," routes Portability check (the main focus area):
Two minor nits posted inline, both low severity:
No security, correctness, or shell/Ruby safety issues found. Shell test additions follow existing conventions (quoting, |
Review SummaryReviewed the full diff (bin/install-agent-workflows-test.bash, bin/validate, docs/agent-runner-restarts.md, docs/pr-batch-skills.md, skills/plan-pr-batch/SKILL.md, skills/plan-pr-batch/scripts/check_goal_prompt_size.rb, skills/pr-batch/SKILL.md, workflows/pr-processing.md) with a focus on code quality, bugs, security, performance, portability of shared skills/workflows, and shell/Ruby helper safety. Verdict: no blocking issues. This PR has already been through many review rounds (visible in the commit history — "Address ... review feedback", "Tighten ... guards", "Fix installed prompt guard compatibility", "Gate restart docs drift check explicitly", etc.), and the issues raised by earlier automated passes (real-looking PR numbers in pressure scenarios, missing existence guard on Portability (main focus area) — clean:
Ruby helper safety — Shell safety — the new Minor, non-blocking FYI (pre-existing, out of scope for this diff): No security or performance concerns — this is a docs/prompt-text change plus a local validation script with no new external input handling. |
…h-merge-readiness-route * origin/main: [codex] Make plan-pr-batch goals Codex-pasteable (#50) [codex] Add host adapter and Codex plugin metadata [codex] Add pause restart prompt skill [codex] Add batch titles and audit defaults [codex] Fix PR-batch Goal-mode completion contract (#52) Add strict trust mode to preflight (#48) [codex] Add generic PR-batch continuation prompt (#49)
Summary
Validation
ruby skills/plan-pr-batch/scripts/check_goal_prompt_size.rbbin/validate