Skip to content

Change merge submission mode to merge_queue_only - #412

Merged
justin808 merged 1 commit into
mainfrom
justin808-patch-1
Aug 11, 2026
Merged

Change merge submission mode to merge_queue_only#412
justin808 merged 1 commit into
mainfrom
justin808-patch-1

Conversation

@justin808

@justin808 justin808 commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Configuration
    • Updated submission handling so changes are processed through the merge queue instead of being merged directly.

@justin808
justin808 added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit 9084f4f Aug 11, 2026
2 of 4 checks passed
@justin808
justin808 deleted the justin808-patch-1 branch August 11, 2026 09:24
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a486d175-162a-4971-aed0-3152676d20e4

📥 Commits

Reviewing files that changed from the base of the PR and between 47a783d and 016029f.

📒 Files selected for processing (1)
  • .agents/agent-workflow.yml

Walkthrough

The agent workflow now requires merge-queue-only submissions instead of direct submissions.

Changes

Submission Policy

Layer / File(s) Summary
Require merge queue submissions
.agents/agent-workflow.yml
merge_submission.mode changes from direct to merge_queue_only.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch justin808-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

ci_change_detector: "n/a"
merge_submission:
mode: direct
mode: merge_queue_only

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per docs/seam-design.md / workflows/pr-processing.md, an explicit mode: merge_queue_only policy on a queue-disabled base returns a deterministic configuration error before mutation (pr-merge-submit fails closed). Worth double-checking that GitHub Merge Queue is actually enabled for main on this repo before/after this merges — otherwise the automated merge-submission tooling (pr-merge-submit) will start failing closed on every PR here instead of falling back to direct merge.

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Summary

What it does: One-line config change in .agents/agent-workflow.yml, switching this repo's own merge_submission.mode from direct to merge_queue_only.

Code quality

  • Trivial, well-formed YAML change; no syntax issues.
  • merge_queue_only is a documented, supported value for this seam (see docs/seam-design.md, docs/adoption.md, workflows/pr-processing.md, skills/pr-batch/SKILL.md), and the same value is already exercised in test/fixtures/consumer-repo/.agents/agent-workflow.yml, so the value itself is known-good and not a typo/unsupported option.

Potential issues / risk (see inline comment)

  • Per the seam docs, an explicit mode: merge_queue_only policy on a queue-disabled base fails closed before mutation with a deterministic configuration error — pr-merge-submit will refuse to merge rather than falling back to direct merge. Since this changes the live policy for this repo's own PRs, it's worth confirming GitHub's Merge Queue is actually enabled for main on shakacode/agent-workflows. If it isn't, this change will break automated merge submission for future PRs here.
  • The PR description is empty, so there's no stated rationale for the switch (e.g., "we just enabled Merge Queue on main") — a short description would help future readers/auditors understand why this seam value changed.

Security / performance

  • No security or performance implications; this is a policy/config value consumed by internal tooling, not user-facing or executable code.

Test coverage

  • No test changes accompany this PR, but none seem necessary — the value is a pre-validated enum already covered by existing fixtures/config-validation tests.

Recommendation: Looks safe to have merged as long as Merge Queue is confirmed enabled for main; otherwise, flip back to direct (or merge_queue_or_guarded_direct) to avoid fail-closed merge failures.

justin808 added a commit that referenced this pull request Aug 11, 2026
…gn-implementation

* origin/main:
  Harden coordination parsing after PR #339 audit (#410)
  Change merge submission mode to merge_queue_only (#412)
  Scope archive-readiness, add retry heartbeat and launch modes, ship the batch-status skill (#362)
  Default merge submission to direct (#407)
  Fix <PROJECT> digit ambiguity, anchor section extraction, ship coordination gate (#339)
justin808 added a commit that referenced this pull request Aug 12, 2026
…itable-controls

* origin/main:
  Suppress unchanged Goal monitor wakes (#395)
  Document single-target plan-pr-batch routing (#405)
  Require exact-head hosted QA before merge (#291)
  Change merge mode from queue to direct (#415)
  Harden coordination parsing after PR #339 audit (#410)
  Change merge submission mode to merge_queue_only (#412)
  Scope archive-readiness, add retry heartbeat and launch modes, ship the batch-status skill (#362)
  Default merge submission to direct (#407)
  Fix <PROJECT> digit ambiguity, anchor section extraction, ship coordination gate (#339)
  Enforce requested-versus-observed model route provenance (#348)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant