Skip to content

refactor: migrate to vite-plus unified toolchain - #3033

Draft
setchy wants to merge 8 commits into
mainfrom
chore/vite-plus-migration
Draft

refactor: migrate to vite-plus unified toolchain#3033
setchy wants to merge 8 commits into
mainfrom
chore/vite-plus-migration

Conversation

@setchy

@setchy setchy commented Jun 9, 2026

Copy link
Copy Markdown
Owner

closes: #3028

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploy Preview for atlassify canceled.

Name Link
🔨 Latest commit 4262e5f
🔍 Latest deploy log https://app.netlify.com/projects/atlassify/deploys/6a4c28788755a40009032774

@setchy

setchy commented Jun 28, 2026

Copy link
Copy Markdown
Owner Author

note 0.2.1 needs some manual migration steps: see https://github.com/voidzero-dev/vite-plus/releases/tag/v0.2.1

setchy added 4 commits July 6, 2026 16:49
# Conflicts:
#	.github/workflows/zizmor.yml
#	README.md
#	biome.json
#	docs/package.json
#	package.json
#	pnpm-lock.yaml
#	pnpm-workspace.yaml
#	src/main/events.test.ts
#	src/main/events.ts
#	tailwind.config.mts
#	vite.config.ts
vite-plus@0.2.2 bundles vitest@4.1.9 internally. Having @vitest/coverage-v8 and
@vitest/ui at 4.1.10 causes a mixed-versions warning and snapshot client errors.

Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@github-actions github-actions Bot added dependency Dependency updates refactor Refactoring of existing feature labels Jul 6, 2026
setchy added 3 commits July 6, 2026 17:28
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@setchy

setchy commented Jul 7, 2026

Copy link
Copy Markdown
Owner Author

@copilot let's review this PR

Copilot AI commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@copilot let's review this PR

Here's my review of the vite-plus migration:

Overall: The migration looks clean and well-executed. Key items are correctly handled:

vite-plus@0.2.2 installed (0.2.2 > 0.2.1 migration requirements)
@voidzero-dev/vite-plus-test fully removed — not present in package.json, lockfile, or any source files
vite.config.ts now imports defineConfig and Plugin from vite-plus directly and consolidates lint, fmt, and staged configuration
package.json scripts updated to use vp check, vp lint, vp fmt, vp test
✅ Direct vitest usage (Case B): vitest@4.1.9, @vitest/coverage-v8@4.1.9, and @vitest/ui@4.1.9 are all pinned consistently — no duplicate vitest versions in the lockfile
✅ No browser-mode vitest (project uses node + happy-dom environments only, so no extra @vitest/browser-playwright pin is needed)
✅ No stale peerDependencyRules referencing vitest or the old wrapper

One thing worth verifying: The v0.2.1 migration guide specifies keeping a vite → npm:@voidzero-dev/vite-plus-core override in pnpm-workspace.yaml. This project doesn't have that override (the lockfile shows vite@8.1.3 resolving as the real Rolldown-based Vite, not an alias to vite-plus-core). Since all config imports come from vite-plus directly rather than from vite, and the plugins peer-depend on vite@8.x which is already Rolldown-based, this appears intentional. Worth confirming with vp check that no warning is raised about this.

Everything else is in order — the migration follows the 0.2.1 upgrade guide for a node-mode project with direct vitest usage.

Copilot finished work on behalf of setchy July 7, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency Dependency updates refactor Refactoring of existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate toolchain to vite-plus

2 participants