Skip to content

Force clang to treat all input files as C++.#40

Open
jdm wants to merge 2 commits into
mainfrom
jdm-patch-5
Open

Force clang to treat all input files as C++.#40
jdm wants to merge 2 commits into
mainfrom
jdm-patch-5

Conversation

@jdm

@jdm jdm commented Jun 26, 2020

Copy link
Copy Markdown
Member

Fixes #38. sccache guesses what mode to run the compiler in based on the filename, which makes clang complain when we pass C++ flags when building C files. Forcing C++ mode causes sccache to skip the heuristic and clang happily compiles.

@jdm

jdm commented Jun 26, 2020

Copy link
Copy Markdown
Member Author

r? @jrmuizel

@jdm

jdm commented Jul 8, 2020

Copy link
Copy Markdown
Member Author

The windows failure is #41.

@bors-servo

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #50) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't build with new versions of cc-rs when using sccache

2 participants