Support subdomain matching#34
Merged
Merged
Conversation
strzibny
requested changes
Jun 29, 2026
strzibny
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot David. This is good.
I think you missed the main place where we need to pass the match_subdomains which is here:
serptrail/app/jobs/keyword_check_job.rb
Line 34 in f309c1b
I also left some small comments that would also be nice to address.
Contributor
Author
Thanks @strzibny, I'd adjusted that line previously but I guess I missed committing it and clearly blew it away with another command 😅 -- added it back in now. Have also addressed the other comments. |
Contributor
|
Thanks David. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include?would be used to check but it would falsely match if the domain was anywhere in the URL, e.g. for the domainexample.com, it would also match this URL:https://site.info/example.comor this URL:https://www.weareexample.com/match_subdomainattribute to siteswww.prefixes also considered as matching) will be considered a match