Refactor name controller with concerns#288
Merged
Merged
Conversation
vangberg
added a commit
that referenced
this pull request
Jun 30, 2026
`NamesController#user` sets `params[:status] = 'all'`. Before pull request #288 this was converted into `opts[:status] = nil`: ```ruby opts[:status] ||= case @status.to_s.downcase when 'public'; Name.public_status when 'automated'; 0 when 'seqcode'; 15 when 'icnp'; 20 when 'icnafp'; 25 when 'valid'; Name.valid_status end ``` The pull request changed that code to call `map_status_to_value`, which returns `'all'`. This in turn would be sent to `apply_name_filters` which would create the condition `WHERE status = 'all'`, returning nothing. By explicitly returning `nil` instead, no conditions on `status` are imposed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.