Skip to content

test: Add tests for Project files. - #49

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
pjhampton:pjhampton/add-tests
Oct 31, 2017
Merged

test: Add tests for Project files.#49
mbernier merged 1 commit into
sendgrid:masterfrom
pjhampton:pjhampton/add-tests

Conversation

@pjhampton

Copy link
Copy Markdown
Contributor

Fixes #47

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds tests to check that various files / dirs exists in the projects repo.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX

SendGridDX commented Oct 28, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mbernier

Copy link
Copy Markdown

We are just waiting on someone to fix up #51 to merge this in!

@pjhampton

Copy link
Copy Markdown
Contributor Author

Hey @mbernier. Sure, no rush 😄

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
@mbernier

Copy link
Copy Markdown

Your code is running fine, we're good to go. Thank you!

ProjectTest > checkLicenseExists FAILED
java.lang.AssertionError at ProjectTest.java:63
ProjectTest > checkCodeClimateExists FAILED
java.lang.AssertionError at ProjectTest.java:38
ProjectTest > checkDockerComposeExists FAILED
java.lang.AssertionError at ProjectTest.java:18
ProjectTest > checkEnvSampleExists FAILED
java.lang.AssertionError at ProjectTest.java:23
ProjectTest > checkUsageGuideExists FAILED
java.lang.AssertionError at ProjectTest.java:83
ProjectTest > checkDockerExists FAILED
java.lang.AssertionError at ProjectTest.java:13
ProjectTest > checkUseCases FAILED
java.lang.AssertionError at ProjectTest.java:88

@mbernier
mbernier merged commit 93ee939 into sendgrid:master Oct 31, 2017
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @pjhampton,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@eshanholtz eshanholtz changed the title Add tests for Project files. test: Add tests for Project files. Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unittest to check for specific repo files

4 participants