fix: Utilize headers set on the Request object - #657
Merged
Conversation
thinkingserious
added
the
status: code review request
prputnam
force-pushed
the
fix-use-request-headers
branch
from
December 3, 2020 18:41
d080ec0 to
4eaa0c4
Compare
Contributor
Author
|
Looks like the CI failure occurred when attempting to grab an artifact. I'm going to close and re-open this PR with the hope it triggers another CI run. |
eshanholtz
approved these changes
Dec 4, 2020
eshanholtz
left a comment
eshanholtz
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks for the contribution!
Contributor
Author
|
Thanks for the merge! Is there a regular release cadence for this library? |
Contributor
|
Yup! We release bi-weekly, next one's scheduled for 2020-12-16. |
Contributor
Author
|
Okay, great! Thanks @eshanholtz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214
This PR makes it so
headersset on aRequestobject are utilized in final request sent to the SendGrid API. Currently, only the header values set on theSendGridobject itself are utilized.I also swapped the
for eachout forputAll- certainly not married to that change if it is unwarranted.