Skip to content

docs: Update the link for Google's Style Guide - #540

Merged
childish-sambino merged 1 commit into
sendgrid:masterfrom
RohanTalip:style
Feb 14, 2020
Merged

docs: Update the link for Google's Style Guide#540
childish-sambino merged 1 commit into
sendgrid:masterfrom
RohanTalip:style

Conversation

@RohanTalip

Copy link
Copy Markdown
Contributor

... from the out-of-date http://checkstyle.sourceforge.net/reports/google-java-style.html (last updated 2014-03-21)
... to https://google.github.io/styleguide/javaguide.html (last updated 2018-05-22)

See also https://github.com/google/styleguide/blob/gh-pages/javaguide.html

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
    • Not applicable; there is no development branch yet.
  • I have added tests that prove my fix is effective or that my feature works
    • Not applicable.
  • I have added necessary documentation about the functionality in the appropriate .md file
    • Not applicable.
  • I have added in line documentation to the code I modified
    • Not applicable.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty status: hacktoberfest approved labels Oct 31, 2018

@pavan-kalyan pavan-kalyan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@childish-sambino childish-sambino changed the title Updated the link for Google's Style Guide docs: Update the link for Google's Style Guide Feb 14, 2020
@childish-sambino
childish-sambino merged commit 0742567 into sendgrid:master Feb 14, 2020
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @RohanTalip,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@RohanTalip
RohanTalip deleted the style branch February 20, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants