Use normal Java conventions for file/package naming. - #438
Closed
marshallpierce wants to merge 2 commits into
Closed
Use normal Java conventions for file/package naming.#438marshallpierce wants to merge 2 commits into
marshallpierce wants to merge 2 commits into
Conversation
com.foo.bar.Baz should be in com/foo/bar/Baz.java.) To avoid a breaking change, I moved the files to match their existing packages, not the other way around. Also, moved ContentVerifier to be an inner static class, and added trailing newlines to appease picky text editors. Having non-standard file layout, or >1 top level classes per file, makes incremental builds unreliable since build tools won't know where to look for a class.
thinkingserious
added
the
status: code review request
(with some editing) into the class javadoc because it would be confusing to have a README.md in the main package that only referred to one class.
Contributor
|
Thank you @marshallpierce! I've added this one to our backlog for review. |
Contributor
|
It looks like the travis-ci build for oraclejdk8 failed due to missing Javadoc: |
Contributor
|
Thanks for the heads up @RohanTalip! |
thinkingserious
added
type: community enhancement
childish-sambino
removed
the
type: community enhancement
Contributor
|
Duplicate of #306 |
childish-sambino
added
status: duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Short description of what this PR does:
(Class com.foo.bar.Baz should be in com/foo/bar/Baz.java.) To avoid a breaking
change, I moved the files to match their existing packages, not the
other way around.
Also, moved ContentVerifier to be an inner static class, and added
trailing newlines to appease picky text editors.
Having non-standard file layout, or >1 top level classes per file, makes
incremental builds unreliable since build tools won't know where to look
for a class.