Skip to content

docs: Fixes Javadoc errors in Attachments.java - #418

Merged
childish-sambino merged 4 commits into
sendgrid:mainfrom
pacbac:pacbac-javadoc-fix
Nov 6, 2020
Merged

docs: Fixes Javadoc errors in Attachments.java#418
childish-sambino merged 4 commits into
sendgrid:mainfrom
pacbac:pacbac-javadoc-fix

Conversation

@pacbac

@pacbac pacbac commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

Fixes #412

Description of what this PR fixes:

  • Adds @return for appropriate methods
  • Deleted an extra @param apiKey in attachments build()

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 17, 2018
@SendGridDX

SendGridDX commented Jan 17, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@thinkingserious

Copy link
Copy Markdown
Contributor

Thanks @pacbac,

This is now on our backlog for review.

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty labels Sep 28, 2018
@childish-sambino childish-sambino removed the type: bug bug in the library label Jul 20, 2020
@thinkingserious
thinkingserious changed the base branch from master to main July 28, 2020 14:33
@childish-sambino childish-sambino changed the title Fixes Javadoc errors in Attachments.java and SendGridAPI.java docs: Fixes Javadoc errors in Attachments.java Nov 6, 2020
@childish-sambino
childish-sambino merged commit baad444 into sendgrid:main Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Javadoc failures during Travis Build - @param doesn't exist

4 participants