Skip to content

docs: makes Environmental Variables a sub topic in CONTRIBUTING.md - #387

Merged
childish-sambino merged 1 commit into
sendgrid:masterfrom
thepriefy:patch-1
Feb 4, 2020
Merged

docs: makes Environmental Variables a sub topic in CONTRIBUTING.md#387
childish-sambino merged 1 commit into
sendgrid:masterfrom
thepriefy:patch-1

Conversation

@thepriefy

@thepriefy thepriefy commented Oct 31, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • makes Environmental Variables a sub topic

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thepriefy
update CONTRIBUTING.md
c43c399 
makes Environmental Variables a sub topic
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
madhavimishra
madhavimishra approved these changes Feb 13, 2018
View reviewed changes

@madhavimishra madhavimishra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code and removed hacktoberfest labels Sep 28, 2018
@childish-sambino childish-sambino changed the title update CONTRIBUTING.md docs: makes Environmental Variables a sub topic in CONTRIBUTING.md Feb 4, 2020
@childish-sambino
childish-sambino merged commit c8fb5a6 into sendgrid:master Feb 4, 2020
@thinkingserious

thinkingserious commented Feb 4, 2020

Copy link
Copy Markdown
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@madhavimishra madhavimishra madhavimishra approved these changes
@childish-sambino childish-sambino childish-sambino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thepriefy @thinkingserious @madhavimishra @childish-sambino @apigirl