Skip to content

The license file is put into the release jar. - #223

Merged
thinkingserious merged 4 commits into
sendgrid:masterfrom
sccalabr:license
Oct 31, 2017
Merged

The license file is put into the release jar.#223
thinkingserious merged 4 commits into
sendgrid:masterfrom
sccalabr:license

Conversation

@sccalabr

@sccalabr sccalabr commented Oct 1, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@SendGridDX

SendGridDX commented Oct 1, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sccalabr

sccalabr commented Oct 1, 2017

Copy link
Copy Markdown
Contributor Author

#206

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 1, 2017
@thinkingserious

Copy link
Copy Markdown
Contributor

Hi @sccalabr,

In order to merge your work, we need you to sign our CLA. It's a quick web form.

Also, it looks like you need to update your email address with GitHub.

Thanks!

With Best Regards,

Elmer

Comment thread pom.xml Outdated
</dependency>
</dependencies>
</project>
</project> No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline at the end of the file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@andy-trimble

Copy link
Copy Markdown
Contributor

LGTM

@sccalabr

sccalabr commented Oct 22, 2017

Copy link
Copy Markdown
Contributor Author

Is there anything else I need to do for this one? @andy-trimble

@mbernier

Copy link
Copy Markdown
Contributor

merge merge merge. I am merging all the things.

@sccalabr

sccalabr commented Oct 29, 2017

Copy link
Copy Markdown
Contributor Author

Thanks @mbernier !!!! Do I get an email when it is merged? Do I need to close the pull request?

@thinkingserious
thinkingserious merged commit a7f9823 into sendgrid:master Oct 31, 2017
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @sccalabr,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@sccalabr

sccalabr commented Nov 1, 2017

Copy link
Copy Markdown
Contributor Author

Hi @thinkingserious

I try filling out the form and I get

I don't know who you are; I should, but regretfully I don't.

What should I do to fix that?
sccalabr

@mbernier

Copy link
Copy Markdown
Contributor

@sccalabr

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants