Skip to content

Rename Segment namespace to SegmentIO to reduce collision probability#259

Closed
taschetto wants to merge 2 commits into
segmentio:masterfrom
tatango:rename-namespace
Closed

Rename Segment namespace to SegmentIO to reduce collision probability#259
taschetto wants to merge 2 commits into
segmentio:masterfrom
tatango:rename-namespace

Conversation

@taschetto

@taschetto taschetto commented Jan 19, 2023

Copy link
Copy Markdown

Fixes #256.

cc @iain-bryson

@taschetto taschetto marked this pull request as ready for review January 19, 2023 14:07
@taschetto taschetto changed the title Rename a generic Segment namespace to a more specific one Rename Segment namespace to SegmentIO to reduce collision probability Jan 19, 2023
@taschetto

Copy link
Copy Markdown
Author

Can we move this forward, please? @nd4p90x @pooyaj @MichaelGHSeg

@MichaelGHSeg

Copy link
Copy Markdown
Contributor

Unfortunately, after discussing this internally, we decided we won't be able to rename the namespace.

You may be able to work around it in your code with an approach like this: https://stackoverflow.com/questions/11091740/is-it-possible-to-make-an-alias-for-a-module-in-ruby

@taschetto

Copy link
Copy Markdown
Author

Thanks for the feedback @MichaelGHSeg

@JewelSam

Copy link
Copy Markdown

Hello guys
I guess this change was mistakenly added to the changelog of v2.5.0 which is a bit confusing.

@nd4p90x

nd4p90x commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

Thanks for letting us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

::Segment is too generic a namespace

4 participants