enable-overriding-transport-options Pass options when initializing Transport#230
Merged
pooyaj merged 2 commits intoMay 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 12 12
Lines 474 474
=======================================
Hits 470 470
Misses 4 4
Continue to review full report at Codecov.
|
Contributor
Author
|
Hi @pooyaj, I was wondering if I can get your feedback on this PR? Thank you! |
nd4p90x
approved these changes
May 5, 2021
Contributor
Author
|
@nd4p90x thanks for approving, I was wondering if the new version of gem will get published soon? |
Collaborator
We are working on this now :) |
Contributor
Author
|
Awesome, thank you! |
Contributor
|
@annc128 New version ( 2.4.0 ) has been released! |
Contributor
Author
|
@pooyaj Much appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will allow users to override the default options so the library can be more flexible