Skip to content

Changed the fractional digits to display 6 places#225

Merged
pooyaj merged 7 commits into
segmentio:masterfrom
North-Two-Five:Issue-#223-Sub-Millisecond-Timestamp
Mar 26, 2021
Merged

Changed the fractional digits to display 6 places#225
pooyaj merged 7 commits into
segmentio:masterfrom
North-Two-Five:Issue-#223-Sub-Millisecond-Timestamp

Conversation

@nd4p90x

@nd4p90x nd4p90x commented Mar 24, 2021

Copy link
Copy Markdown
Collaborator

Issue #223 Update the default originalTimestamp to send 6 decimal places to the server

@nd4p90x nd4p90x linked an issue Mar 24, 2021 that may be closed by this pull request
@pooyaj pooyaj self-requested a review March 26, 2021 16:51

@pooyaj pooyaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, looks great 💥 let's decide on the versioning and then merge

Comment thread lib/segment/analytics/version.rb
@nd4p90x nd4p90x self-assigned this Mar 26, 2021
@codecov-io

codecov-io commented Mar 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #225 (a8558ea) into master (b6681ff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          11       11           
  Lines         438      438           
=======================================
  Hits          434      434           
  Misses          4        4           
Impacted Files Coverage Δ
lib/segment/analytics/utils.rb 100.00% <100.00%> (ø)
lib/segment/analytics/transport.rb 100.00% <0.00%> (ø)
lib/segment/analytics/field_parser.rb 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6681ff...a8558ea. Read the comment docs.

@pooyaj pooyaj merged commit abb6fc7 into segmentio:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce sub millisecond timestamps

3 participants