Add test option and queue for easier testing#222
Conversation
|
@rohitpaulk I see you are a major contributor here, and I was hoping to get some feedback on this update. Thanks! |
|
@ryanwjackson Do you mind rebasing this branch with master? Once that is complete I will re-review the PR. Thank you. |
|
@nd4p90x just rebased. |
|
@ryanwjackson Thanks for the rebase, however, all of the test cases are failing due to the use of double quotes on all of the variables. Could you modify the tests and update the variables to be encapsulated by single quotes as to pass the ci tests? Thank you. |
|
@nd4p90x just updated. |
nd4p90x
left a comment
nd4p90x
left a comment
There was a problem hiding this comment.
Thank you for the updates
|
@nd4p90x do you know when this will get released? |
|
@ryanwjackson the PR has been merged into the master branch, is that what you are referring to? Thanks. |
|
@nd4p90x I meant when a new gem version will be released that includes this update. |
|
@ryanwjackson Ah, sorry for the confusion working on that now. |
4 participants
Currently, we need to manually stub and override various functions within the gem to make it possible to test in rspec. This PR adds that functionality as an option to the gem itself. Perhaps also helpful, but not included here, would be some spec helpers for analytics (which we also have developed ourselves). Appreciate any feedback!