Skip to content

Fix stubbed request message#212

Merged
rohitpaulk merged 1 commit into
segmentio:masterfrom
mbirman:fix-stubbed-request-message
Nov 29, 2019
Merged

Fix stubbed request message#212
rohitpaulk merged 1 commit into
segmentio:masterfrom
mbirman:fix-stubbed-request-message

Conversation

@mbirman

@mbirman mbirman commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

The client logs invalid data in the stubbed mode.

Example message: [analytics-ruby] stubbed request to /v1/import: write key = test-key, batch = JSON.generate(#<Segment::Analytics::MessageBatch:0x00007fe40420b490>)

Expected: actual hash instead of <Segment::Analytics::MessageBatch:0x00007fe40420b490>.

@codecov-io

codecov-io commented Nov 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          11       11           
  Lines         433      433           
=======================================
  Hits          429      429           
  Misses          4        4
Impacted Files Coverage Δ
lib/segment/analytics/request.rb 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2b0b8...6bba4b7. Read the comment docs.

@rohitpaulk

Copy link
Copy Markdown
Collaborator

Thanks, @mbirman!

@rohitpaulk rohitpaulk merged commit 9347bdd into segmentio:master Nov 29, 2019
@mbirman mbirman deleted the fix-stubbed-request-message branch November 29, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants